Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Enhancement the config manage for project #2576

Closed
2 tasks done
githublaohu opened this issue Dec 13, 2022 · 0 comments · Fixed by #2804, #2861, #2911 or #2917
Closed
2 tasks done

[Enhancement] Enhancement the config manage for project #2576

githublaohu opened this issue Dec 13, 2022 · 0 comments · Fixed by #2804, #2861, #2911 or #2917
Assignees
@githublaohu
Labels
enhancement New feature or request

Comments

@githublaohu
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Enhancement the config manage for project

Describe the solution you'd like

Enhancement the config manage for project

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@githublaohu githublaohu added the enhancement New feature or request label Dec 13, 2022
githublaohu added a commit to githublaohu/incubator-eventmesh that referenced this issue Dec 13, 2022
@githublaohu
[ISSUE apache#2576]Enhancement the config manage for project
cfe608d
@githublaohu githublaohu mentioned this issue Dec 13, 2022
Merged
xwm1992 added a commit that referenced this issue Dec 13, 2022
@xwm1992
Merge pull request #2577 from githublaohu/laohu-master
0c783a7 
[ISSUE #2576]Enhancement the config manage for project
@xwm1992 xwm1992 mentioned this issue Dec 15, 2022
Merged
xwm1992 added a commit that referenced this issue Dec 20, 2022
@xwm1992
Merge pull request #2586 from eight-nines/MR1
b9ca4f2 
[ISSUE #2576] Improve the configuration management code framework
This was referenced Dec 20, 2022
Merged
Merged
xwm1992 added a commit that referenced this issue Dec 23, 2022
@xwm1992
Merge pull request #2637 from eight-nines/MR1
9d2ef64 
[ISSUE #2576] Improve configuration management of SPI implementations
@eight-nines eight-nines mentioned this issue Dec 23, 2022
Merged
xwm1992 added a commit that referenced this issue Dec 31, 2022
@xwm1992
Merge pull request #2680 from eight-nines/MR1
027ebd5 
[ISSUE #2576] Improve configuration management of Kafka and Redis SPI Impl
This was referenced Jan 1, 2023
Merged
Merged
Merged
xwm1992 added a commit that referenced this issue Jan 3, 2023
@xwm1992
Merge pull request #2796 from eight-nines/MR2
86392fa 
[ISSUE #2576] Improve configuration management of Pravega、Pulsar、Rabbitmq、AuthHttpBasic 、Prometheus  SPI Impl
@eight-nines eight-nines mentioned this issue Jan 3, 2023
Merged
xwm1992 added a commit that referenced this issue Jan 5, 2023
@xwm1992
Merge pull request #2804 from eight-nines/MR2
74025dc 
[ISSUE #2576] Improve configuration management of TracePlugin
@eight-nines eight-nines mentioned this issue Jan 8, 2023
Merged
@xwm1992 xwm1992 added this to the 1.8.0 milestone Jan 9, 2023
xwm1992 added a commit that referenced this issue Jan 10, 2023
@xwm1992
Merge pull request #2861 from eight-nines/MR2
4c67dcd 
[ISSUE #2576] Improve configuration management of WebHook
@eight-nines eight-nines mentioned this issue Jan 10, 2023
Merged
xwm1992 added a commit that referenced this issue Jan 11, 2023
@xwm1992
Merge pull request #2896 from eight-nines/MR2
e8215b8 
[ISSUE #2576] Change CommonConfiguration and subclass to new framework
@eight-nines eight-nines mentioned this issue Jan 11, 2023
Merged
xwm1992 added a commit that referenced this issue Jan 12, 2023
@xwm1992
Merge pull request #2911 from eight-nines/MR2
bd58346 
[ISSUE #2576] Change Configuration to new framework
@xwm1992 xwm1992 reopened this Jan 12, 2023
@xwm1992 xwm1992 removed this from the 1.8.0 milestone Jan 12, 2023
@eight-nines eight-nines mentioned this issue Jan 12, 2023
Merged
jonyangx pushed a commit that referenced this issue Jan 14, 2023
@eight-nines @githublaohu @xwm1992
[ISSUE #2576] Enhanced Configuration management (#2917)
fc7825e 
* [ISSUE #2576]Enhancement the config manage for project

* [1] test code

* EventMeshServer config improve

* Extract the key prefix of the @configFiled field into @config

* Improve configuration management of SPI implementations
[1] config improve of RocketMQProducerImpl and RocketMQConsumerImpl
[2] config UT of RocketMQProducerImpl and RocketMQConsumerImpl

* Improve configuration management of SPI implementations
[1] extensionInstance config init process improve
[2] RocketMQProducerImpl and RocketMQConsumerImpl config UT improve

* Improve configuration management of Kafka SPI Impl
[1] KafkaConsumerImpl and KafkaProducerImpl config improve
[2] KafkaConsumerImpl and KafkaProducerImpl config UT

* Improve configuration management of Redis SPI Impl
[1] RedisProperties config improve

* Improve configuration management of Redis SPI Impl
[1] RedisProperties config and UT improve
[2] New parser ConvertProperties
[3] To fix a bug where parser convertEnum could not parse null values

* Fix config UT of Redis SPI Impl

* Tweak Convert's code framework, for ease of enhancement (#2784)

[1] Split the converter classes in Convert into separate files
[2] Add the converter field to ConfigFiled, used to specify the converter class of the field

* Improve configuration management of Knative SPI Impl (#2791)

[1] KnativeConsumerImpl and KnativeProducerImpl config improve
[2] KnativeConsumerImpl and KnativeProducerImpl config UT

* Improve configuration management of Pravega SPI Impl

[1] PravegaConsumerImpl and PravegaProducerImpl config improve
[2] PravegaConsumerImpl and PravegaProducerImpl config UT
[3] add new converter URIConverter

* Improve configuration management of Pulsar SPI Impl

[1] PulsarConsumerImpl and PulsarProducerImpl config improve
[2] PulsarConsumerImpl and PulsarProducerImpl config UT

* Improve configuration management of Rabbitmq SPI Impl

[1] RabbitmqConsumer and RabbitmqProducer config improve
[2] RabbitmqConsumer and RabbitmqProducer config UT

* Improve configuration management of Prometheus SPI Impl

[1] PrometheusMetricsRegistry config improve
[2] PrometheusMetricsRegistry config UT

* Improve configuration management of AuthHttpBasic SPI Impl

[1] AuthHttpBasicService config improve
[2] AuthHttpBasicService config UT

* Enhance configuration management capabilities - @configFiled

[1] Add two properties to @configFiled,findEnv / notNull, and the configuration file parsing capabilities that go with them
[2] Delete @NotNull and replace it with @ConfigFiled.notNull

* Improve configuration management of Pinpoint SPI Impl

[1] PinpointTraceService config improve
[2] PinpointTraceService config UT

* Improve configuration management of Zipkin SPI Impl

[1] ZipkinTraceService config improve
[2] ZipkinTraceService config UT

* Add repeatable functionality to @config

For tagging multiple configuration fields on a class

* Improve configuration management of TracePlugin

[1] ExporterConfiguration config improve
[2] ExporterConfiguration config UT

* Improve configuration management of WebHook

[1] WebHook config improve
[2] WebHook config UT

* Add field beNumber for @configFiled

[1] If String config field not a number, an exception is thrown

* Change the configuration management class CommonConfiguration to a new framework

[1] Replace the CommonConfiguration field modifier public with private
[2] Use getter/setter methods to access it

* Change CommonConfiguration subclass to new framework

[1] EventMeshHTTPConfiguration/EventMeshGrpcConfiguration/EventMeshTCPConfiguration

* Change CommonConfiguration and subclass to new framework

[1] EventMeshHTTPConfiguration/EventMeshGrpcConfiguration/EventMeshTCPConfiguration

* Add field notEmpty for @configFiled

[1] If it cannot be empty but is empty, an exception is thrown

* Change the SPI RocketMQ config to new framework

* Change the SPI kafka config to new framework

* Change the SPI Redis config to new framework

* Change the SPI knative config to new framework

* Change the SPI pravega config to new framework

* Change the SPI pulsar config to new framework

* Change the SPI rabbitmq config to new framework

* Change the SPI Prometheus config to new framework

* Change the SPI auth-http-basic config to new framework

* Change the SPI trace-api config to new framework

* Change the SPI pinpoint config to new framework

* Change the SPI zipkin config to new framework

* Use getter/setter methods to access EventMeshGrpcConfiguration

* Use getter/setter methods to access EventMeshHTTPConfiguration

* Enhanced Configuration management

* remove temporary blocking @ignore

* fix styleCheck

* fix UT

* rename ConfigService method

* Revision review comments

* Fixed code review comments
[1] save the last accessible status of reflection field and recovery it after custom operation

* Fixed code review comments
[1] CLASS_PATH_PREFIX/FILE_PATH_PREFIX constants optimization
[2] Some other code details optimization

* Fixed code review comments
[1] add UT for ConfigService#getConfig(ConfigInfo configInfo)

Co-authored-by: githublaohu <2372554140@qq.com>
Co-authored-by: mike_xwm <mike_xwm@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@githublaohu githublaohu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@walterlife @githublaohu @xwm1992