-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kie-issues#843] Generate reproducible dmndefinitions.json. #5676
[kie-issues#843] Generate reproducible dmndefinitions.json. #5676
Conversation
baldimir
commented
Feb 7, 2024
- Orders the types written into dmndefinitions.json file.
kie-dmn/kie-dmn-openapi/src/main/java/org/kie/dmn/openapi/impl/DMNOASGeneratorImpl.java
Show resolved
Hide resolved
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5676 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5676/2/display/redirect Test results:
Those are the test failures: org.kie.dmn.openapi.ProcessItemTest.test_togetherExpecting actual not to be empty |
I will take a look at the test. |
I reverted the change to a TreeMap as that broke one test. With the sorting I had before, it works. For some reason, some other code, where the Map is sent (or its entries), it relies on it not being sorted or similar (Honestly, such reliance look strange to me, it should not happen). It could take much more time to investigate, so I suggest merging this approach and investigating after the release. What do you think please? @mariofusco @yesamer |