Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues#843] Generate reproducible dmndefinitions.json. #5676

Merged

Conversation

baldimir
Copy link
Contributor

@baldimir baldimir commented Feb 7, 2024

  • Orders the types written into dmndefinitions.json file.

@kie-ci3
Copy link

kie-ci3 commented Feb 7, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5676 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5676/2/display/redirect

Test results:

  • PASSED: 21922
  • FAILED: 1

Those are the test failures:

org.kie.dmn.openapi.ProcessItemTest.test_together
Expecting actual not to be empty

@baldimir
Copy link
Contributor Author

baldimir commented Feb 8, 2024

I will take a look at the test.

@baldimir
Copy link
Contributor Author

baldimir commented Feb 8, 2024

I reverted the change to a TreeMap as that broke one test. With the sorting I had before, it works. For some reason, some other code, where the Map is sent (or its entries), it relies on it not being sorted or similar (Honestly, such reliance look strange to me, it should not happen). It could take much more time to investigate, so I suggest merging this approach and investigating after the release. What do you think please? @mariofusco @yesamer

@mariofusco mariofusco merged commit a74b548 into apache:main Feb 9, 2024
8 of 9 checks passed
@baldimir baldimir deleted the dmndefinitions-reproducible-generator branch February 14, 2024 09:14
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Mar 11, 2024
)

* Generate reproducible dmndefinitions.json.

* Replace HashMap with TreeMap.

* Revert TreeMap as that breaks some transitively related code.

* Adding a comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants