Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kie-issues#843] Make Java binaries reproducible #1981

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[kie-issues#843] Make Java binaries reproducible #1981

merged 2 commits into from
Feb 12, 2024

Conversation

baldimir
Copy link
Contributor

@baldimir baldimir commented Feb 7, 2024 •
edited
Loading

Closes apache/incubator-kie-issues#843

@baldimir baldimir mentioned this pull request Feb 7, 2024
Closed
@kie-ci3
Copy link
Contributor

kie-ci3 commented Feb 7, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1981 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1981/1/display/redirect

Test results:

  • PASSED: 2856
  • FAILED: 5

Those are the test failures:

org.kie.kogito.index.infinispan.ProcessDataIndexInfinispanHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path errors doesn't match.
Expected: null
Actual: <[{message=Exception while fetching data (/UserTaskInstanceCommentUpdate) : Index 0 out of bounds for length 0, locations=[{line=1, column=12}], path=[UserTaskInstanceCommentUpdate], extensions={classification=DataFetchingException}}]>
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.oracle.ProcessDataIndexOracleHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null

@yesamer
Copy link
Contributor

yesamer commented Feb 8, 2024

@baldimir oh-ho, We have a conflict here!

@kie-ci3
Copy link
Contributor

kie-ci3 commented Feb 9, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1981 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1981/2/display/redirect

Test results:

  • PASSED: 2815
  • FAILED: 8

Those are the test failures:

org.kie.kogito.index.infinispan.ProcessDataIndexInfinispanHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.infinispan.ProcessDataIndexInfinispanKafkaIT.testProcessInstanceEvents 1 expectation failed.
Expected status code <201> but was <409>.
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents 1 expectation failed.
Expected status code <201> but was <409>.
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents 1 expectation failed.
Expected status code <201> but was <409>.
org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlHttpIT.testProcessInstanceEvents 1 expectation failed.
Expected status code <201> but was <409>.
org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlKafkaIT.testProcessInstanceEvents 1 expectation failed.
Expected status code <201> but was <409>.
org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.ProcessDataIndexPostgreSqlIT.testProcessInstanceEvents 1 expectation failed.
Expected status code <201> but was <409>.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Feb 9, 2024

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1981 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1981/3/display/redirect

Test results:

  • PASSED: 2819
  • FAILED: 4

Those are the test failures:

org.kie.kogito.index.infinispan.ProcessDataIndexInfinispanHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents 1 expectation failed.
JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.
Expected: managers
Actual: null
org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents 1 expectation failed.
JSON path errors doesn't match.
Expected: null
Actual: <[{message=Exception while fetching data (/UserTaskInstances[0]/schema) : Runtime service URL not defined, please review the kogito.service.url system property to point the public URL for this runtime., locations=[{line=1, column=85}], path=[UserTaskInstances, 0, schema], extensions={classification=DataFetchingException}}]>

@baldimir
Copy link
Contributor Author

The test failures are unrelated to my changes. Merging this.

@baldimir baldimir merged commit 5c9341b into apache:main Feb 12, 2024
4 of 5 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-apps that referenced this pull request Mar 11, 2024
@baldimir @rgdoliveira
[kie-issues#843] Make Java binaries reproducible (apache#1981)
e6ac1ec
@baldimir baldimir deleted the reproducible-build branch April 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesamer yesamer yesamer approved these changes

@pefernan pefernan pefernan approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

@mariofusco mariofusco mariofusco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reproducible Build: kogito-apps repo
6 participants
@baldimir @kie-ci3 @yesamer @mariofusco @ricardozanini @pefernan