Update Chinese manual compaction doc #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 12, 2023 11:55
…site into doc_duplication
empiredan
reviewed
Jan 18, 2024
Co-authored-by: Dan Wang <wangdan@apache.org>
Co-authored-by: Dan Wang <wangdan@apache.org>
|
Please add a space between Chinese and letter/digitals, see https://github.com/vinta/pangu.js |
acelyc111
reviewed
Jan 21, 2024
| * Manual Compact总开关： | ||
| * `manual_compact.disabled`(从v1.9.0版本开始支持)：如果为true，则关闭Manual Compact功能，并且取消正在执行中的Manual Compact动作。如果不设置，默认为false。 | ||
| * `manual_compact.max_concurrent_running_count`(从v1.11.3版本开始支持)：指定最大并发数。实际上，可执行的最大并发数由`该env参数`和`服务端MANUAL_COMPACT_THRAD_POOL的线程数`共同决定，取两者的较小值。 | ||
| * 扩展 RocksDB，在 Manifest 中记录上一次执行 Manual Compact 的时间，并提供 `GetLastManualCompactFinishTime()` 方法来获取该时间。 |
There was a problem hiding this comment.
This is the implemantation before 2.1, since 2.1 (include 2.1), the metadata is stored in "meta" column family.
See apache/incubator-pegasus#535, apache/incubator-pegasus#556
You should describe both the two methods in different versions.
|
|
||
| ## 补充说明 | ||
|
|
||
| manual compaction 常与 bulk load 功能配合使用，作为批量导入大量数据后统一优化读取的手段。在需要进行 bulk load 操作的表中，我们常将 **Usage Scenario** 参数设置为 bulk_load 模式，以便减小增加大量数据带来的性能损耗。 |
There was a problem hiding this comment.
Better to write the docs objectively, avoid to say "We often do ...", because this is an open source project, who is we?
|
|
||
| manual compaction 常与 bulk load 功能配合使用，作为批量导入大量数据后统一优化读取的手段。在需要进行 bulk load 操作的表中，我们常将 **Usage Scenario** 参数设置为 bulk_load 模式，以便减小增加大量数据带来的性能损耗。 | ||
|
|
||
| - manual-compaction 的开销要比引擎层 compaction 低，因为我们可以通过参数主动控制并发度。 |
There was a problem hiding this comment.
How do you infer this result? The RocksDB background compaction jobs could be tuned as well.
There was a problem hiding this comment.
I'm going to add a limiting scenario to this result.
|
|
||
| ## 补充说明 | ||
|
|
||
| manual compaction 常与 bulk load 功能配合使用，作为批量导入大量数据后统一优化读取的手段。在需要进行 bulk load 操作的表中，我们常将 **Usage Scenario** 参数设置为 bulk_load 模式，以便减小增加大量数据带来的性能损耗。 |
There was a problem hiding this comment.
Suggested change
| manual compaction 常与 bulk load 功能配合使用，作为批量导入大量数据后统一优化读取的手段。在需要进行 bulk load 操作的表中，我们常将 **Usage Scenario** 参数设置为 bulk_load 模式，以便减小增加大量数据带来的性能损耗。 | |
| Manual compaction 常与 bulk load 功能配合使用，作为批量导入大量数据后的一种优化读写性能的方式。在需要进行 bulk load 操作的表中，可将 [Usage Scenario](/administration/usage-scenario) 设置为`bulk_load`模式，以便减小导入大量数据带来的性能损耗。 |
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
Co-authored-by: Yingchun Lai <laiyingchun@apache.org>
acelyc111
approved these changes
Jan 24, 2024
acelyc111
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update Chinese manual_compaction_doc