Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rocksdb): Remove all calls of Pegasus introduced APIs on RocksDB #556

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Jun 30, 2020

What problem does this PR solve?

Use official RocksdDB

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Test compatibility with 2.0.0:

Code changes

  • Has exported function/method change
    No
  • Has exported variable/fields change
    No
  • Has interface methods change
    No
  • Has persistent data change
    Yes.
    Meta data (Pegasus data version, last manual compact finish timestamp, dcree) will NOT write to RocksDB's manifest anymore.

Side effects

  • Possible performance regression
    No
  • Increased code complexity
    No
  • Breaking backward compatibility
    Upgrade:
    1.x -> this version: forbidden (server will core)
    2.0 -> this version: compatible
    Downgrade:
    this version -> 1.x: forbidden (server will run with error, table can not be healthy, cause 1.x can't open RocksDB with multi-CFs)
    this version -> 2.0: partial compatible, and config [pegasus.server].get_meta_store_type should be metacf in order to read meta data from meta CF.

Related changes

  • Need to cherry-pick to the release branch
    Yes
  • Need to update the documentation.
    Yes
  • Need to be included in the release note
    Yes

@acelyc111 acelyc111 marked this pull request as ready for review July 2, 2020 02:39
@neverchanje neverchanje added the type/incompatible Changes that introduced incompatibility to Pegasus. label Jul 7, 2020
@acelyc111 acelyc111 merged commit d675eda into apache:master Jul 7, 2020
@hycdong hycdong mentioned this pull request Aug 17, 2020
@hycdong hycdong added the type/config-change Added or modified configuration that should be noted on release note of new version. label Aug 18, 2020
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0 type/config-change Added or modified configuration that should be noted on release note of new version. type/incompatible Changes that introduced incompatibility to Pegasus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants