Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test support for arm64 #5069

Merged
merged 2 commits into from
Nov 16, 2022
Merged

test: test support for arm64 #5069

merged 2 commits into from
Nov 16, 2022

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Nov 9, 2022

Added arm64 test support in .github/workflows/test.yml file for running the test for arm64 platform.

Signed-off-by: odidev@puresoftware.com

Signed-off-by: odidev <odidev@puresoftware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #5069 (b9b063f) into develop (f0e25a6) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5069      +/-   ##
=============================================
+ Coverage      49.42%   49.45%   +0.03%     
- Complexity      4125     4126       +1     
=============================================
  Files            734      734              
  Lines          26054    26054              
  Branches        3220     3220              
=============================================
+ Hits           12877    12885       +8     
+ Misses         11803    11793      -10     
- Partials        1374     1376       +2     
Impacted Files Coverage Δ
...erver/storage/file/session/FileSessionManager.java 49.04% <0.00%> (-0.64%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 74.15% <0.00%> (+2.08%) ⬆️

@odidev
Copy link
Contributor Author

odidev commented Nov 15, 2022

@slievrly

Please have a look at the changes and let me know if there is anything else is required from my side.

@slievrly
Copy link
Member

@slievrly

Please have a look at the changes and let me know if there is anything else is required from my side.

it's look good to me, thanks for your contribution.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title test support for arm64 test: test support for arm64 Nov 16, 2022
@slievrly slievrly added this to the 1.6.0 milestone Nov 16, 2022
@slievrly slievrly merged commit acf880a into apache:develop Nov 16, 2022
zw201913 pushed a commit to zw201913/seata that referenced this pull request Nov 16, 2022
…o 1114_for_5073

* '1114_for_5073' of https://github.com/zw201913/seata:
  test: test support for arm64 (apache#5069)
  test: add AT transaction mode tests to support database data types (Oracle) (apache#4411)
  bugfix: fix could not intercept the sql witch has no primary and unique (apache#5078)
  optimize: intercept insert on duplicate update statement which has no primary key and unique index (apache#5075)
  optimize: support oracle date types (apache#4542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants