optimize: support oracle date types #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/io/seata/core/console/result/PageResult.java # server/src/main/java/io/seata/server/storage/SessionConverter.java
jsbxyyx
reviewed
Apr 29, 2022
rm-datasource/src/main/java/io/seata/rm/datasource/util/OffsetTimeUtils.java
Outdated
Show resolved
Hide resolved
jsbxyyx
reviewed
Apr 29, 2022
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableRecords.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Sep 6, 2022
| } | ||
|
|
||
| static { | ||
| ZONE_ID_MAP.put(250, "Asia/Shanghai"); |
There was a problem hiding this comment.
how to ensure all the zone id in the ZONE_ID_MAP ?
There was a problem hiding this comment.
具体解决办法:1维护常用的时区,其他时区通过在配置文件中配置,实时读取相关配置
There was a problem hiding this comment.
how to ensure all the
zone idin theZONE_ID_MAP?
We first add the commonly used time zones, the remaining open interface allows users to manually add their own, 1. api way to add time zones 2. configuration file to add time zones , both options should be supported
slievrly
reviewed
Nov 16, 2022
| */ | ||
| public class OracleJdbcType { | ||
|
|
||
| public static final int TIMESTAMP_WITH_TIME_ZONE = -101; |
There was a problem hiding this comment.
Be careful not to duplicate the int value of java.sql.Types.
There was a problem hiding this comment.
The following are duplicate types:
zw201913
pushed a commit
to zw201913/seata
that referenced
this pull request
Nov 16, 2022
…o 1114_for_5073 * '1114_for_5073' of https://github.com/zw201913/seata: test: test support for arm64 (apache#5069) test: add AT transaction mode tests to support database data types (Oracle) (apache#4411) bugfix: fix could not intercept the sql witch has no primary and unique (apache#5078) optimize: intercept insert on duplicate update statement which has no primary key and unique index (apache#5075) optimize: support oracle date types (apache#4542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
解决AT模式下,oracle数据库不支持以下时间类型:
TIMESTAMP WITH TIME ZONE
TIMESTAMP WITH LOCAL TIME ZONE
此pr解决以上三个类型的支持
Ⅱ. Does this pull request fix one issue?
fixes #4536
Ⅲ. Why don't you add test cases (unit test/integration test)?
yes, test code in # 4411
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews