-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge tooling config into pyproject #1901
Conversation
Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
Cloud Files has no concept of an "internal" CDN so the endpoint type must be hard-coded to "external". Sample Cloud Files service catalog listing: https://docs.rackspace.com/docs/cloud-files/v1/getting-started/authenticate#cloud-files-auth-response
and reformat the code.
…d..d499194be d499194be README: prep 1.0.8 cf52d21d8 Remove pin on requests (fixes apache#41) (apache#42) 3ac8fed01 README: prep 1.0.7 (apache#40) f7e969538 requirements: constrain requests below 2.30 (apache#39) 28aa5e1be New issue templates (apache#37) 1abec09c8 action: replace `internal-be-careful-debug` (apache#36) 75edeacda README: prep 1.0.6 (apache#34) 666b1b883 Check that output file exists before opening (apache#33) git-subtree-dir: .github/actions/gh-action-pip-audit git-subtree-split: d499194be74aeb3bc7dbed3a224a87e1831132c7
just use version which is installed in the end user environment).
changed the default value from no_implicit_optional = false to no_implicit_optional = true.
Also run unit tests under Python 3.12 beta
Thanks for this change 👍 I will go ahead and test it locally and if everything looks fine, merge it into trunk. |
…into rsnk96-merge_pyproject
I tested it locally and everything except mypy change seems to be looking fine. I'll dig in why mypy config is not working as it should and hopefully fix it. Eventually we can also move package metadata from setup.py into pyproject.toml. |
I think 739d053 should do the trick for the MyPy config migration. |
Codecov Report
@@ Coverage Diff @@
## trunk #1901 +/- ##
==========================================
+ Coverage 83.11% 83.12% +0.01%
==========================================
Files 353 353
Lines 81269 81317 +48
Branches 8587 8592 +5
==========================================
+ Hits 67541 67588 +47
- Misses 10922 10924 +2
+ Partials 2806 2805 -1
|
Merged into trunk. Thanks! |
Glad to see it merged @Kami ! :) Had two quick follow up queries, would appreciate it if you could help me out:
|
|
Description
This is a housekeeping MR, meant to simplify the project complexity at root. Tooling and CQ config files (bandit, py-codecoverage, pylint, mypy, pytest) have been moved into
pyproject.toml
, since it is becoming the standard way of defining all tooling-config in python (Ref: https://peps.python.org/pep-0621/)NOTE:
tox.ini
has been left as-is, since it was larger, and probably can be addressed in a separate MR (so that this MR is simple to review). Additionally,flake8
config file has also been left as-is, as they have decided to not yet officially support pyprojecteStatus
Done, ready for review
Checklist (tick everything that applies)
Code linting (required, can be done after the PR checks)(No code changes made)Tests(No functionality added)