-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pytest from 7.4.0 to 8.0.2 #1994
Conversation
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.4.0 to 8.0.2. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.4.0...8.0.2) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Will be able to upgrade once this PR is merged - #1941 |
A newer version of pytest exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
helps with a weird race we started to see more often with latest version of pytest.
#1941 has been merged, but it looks like something else is going on with pytest-xdist plugin and a race condition is bubbling up on each run. I need to dig in more to see why that is the case. |
…see if this" This reverts commit 20ae731.
…nto dependabot/pip/pytest-8.0.2
…nto dependabot/pip/pytest-8.0.2
version (>= 8.0). In theory with mocking in place, those tests should be safe to run in parallel, but because of some reason, they are prone to race condition, but only with pytest >= 8.0.0. To avoid this race condition, we now run tests which are not thread safe separately at the end in non parallel fashion. Tests which are not safe to run in parallel are marked with "serial" pytest marker.
weird race condition we've been seeing.
034f180
to
b83ffc8
Compare
It looks like collection loading mechanism changes in pytest 8.0 (https://docs.pytest.org/en/stable/changelog.html#collection-changes) identified all kinds of cross test pollution and race conditions which only manifest itself when running tests in parallel in specific order. I'm trying to fix it, but it's somewhat problematic since it relies on test ordering and distribution across workers so I can't reliably reproduce it locally. |
b83ffc8
to
4593aa3
Compare
CI test run failures.
we incorrectly used class attribute value instead of the value passed to the method. This could result in all kinds of weird edge cases and test failures in case the environment wasn't correctly reset before / after each test.
b78b55b
to
bb23d9f
Compare
pollution and related failures when running tests in parallel. Also remove other changes which were added which are not actually needed.
bb23d9f
to
7267fc4
Compare
0562748
to
f4fe2fb
Compare
I believe I addressed all the cross test pollution related issue which were causing test failures. I will merge this PR into trunk. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1994 +/- ##
=======================================
Coverage 83.20% 83.20%
=======================================
Files 353 353
Lines 81453 81471 +18
Branches 8594 8594
=======================================
+ Hits 67769 67787 +18
Misses 10874 10874
Partials 2810 2810
|
Bumps pytest from 7.4.0 to 8.0.2.
Release notes
Sourced from pytest's releases.
... (truncated)
Commits
31afeeb
Prepare release version 8.0.21b00a2f
Merge pull request #12025 from pytest-dev/backport-12022-to-8.0.xff2f66d
[8.0.x] Revert "Fix teardown error reporting when--maxfail=1
(#11721)"8a8eed6
[8.0.x] Fix collection of short paths on Windows (#12024)74346f0
[8.0.x] Allow Sphinx 7.x (#12005)b7657b4
[8.0.x] Disallow Sphinx 6 and 7 (#12001)feb7c5e
Merge pull request #11999 from pytest-dev/backport-11996-to-8.0.x0909655
[8.0.x] code: fixIndexError
crash ingetstatementrange_ast
68524d4
Merge pull request #11993 from pytest-dev/release-8.0.1d7d320a
Prepare release version 8.0.1You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)