Mark MockHttp as not for collection by pytest #2014
Conversation
pytest 8.2.0 contains a regression that will collect non-test classes, so as to be explicit about it, mark MockHttp (and therefore all of its children classes) as not to be collected.
| @@ -97,6 +97,8 @@ class MockHttp(LibcloudConnection): | |||
|
|
|||
| (int status, str body, dict headers, str reason) | |||
| """ | |||
| # pytest may collect this class, and we don't need or want that | |||
| __test__ = False | |||
There was a problem hiding this comment.
this hides tests that use a broken inheritance tree
There was a problem hiding this comment.
Can we determine which tests those are? I'm happy to fix them, because otherwise pytest 8.2 collects the class and can not instantiate it.
There was a problem hiding this comment.
I linked one in the upstream bug, at first glance it's not fixable
There was a problem hiding this comment.
Thanks for the contribution.
As @RonnyPfannschmidt pointed out, that will break a bunch of tests which have assertions directly in subclassed MockHttp class (I believe there are quite a few of those).
On a related note, pytest 8.0.x also broke a bunch of other tests recently due to the changes in the test loading / discovery mechanism (#1994). I battle for quite a while to get everything to pass.
Granted, in that specific case, one of the main issues was cross test pollution. Tests would only fail when they ran in a very specific order and that's why we didn't detect that issue earlier and it was hard to track down and fix.
|
Closing as a terrible idea. |
Mark MockHttp as not for collection by pytest
Description
pytest 8.2.0 contains a regression that will collect non-test classes, so as to be explicit about it, mark MockHttp (and therefore all of its children classes) as not to be collected.
pytest regression has been filed upstream as pytest-dev/pytest#12425.
After this merges,
pdmcan upgrade pytest to 8.2.x.Status
Done, ready for review.
Checklist (tick everything that applies)