Fix bug where off-heap scorer would kick on even for float vectors #13850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
requested review from
msokolov and
ChrisHegarty
and removed request for
msokolov
ChrisHegarty
approved these changes
Oct 2, 2024
|
I am gonna merge and backport to 10_0_0 & 10x. I am not putting a changes entry as this could be seen as a bugfix for an unreleased feature (the vector API rewrite), if folks disagree with this, I will happily put a bugfix item. |
benwtrent
added a commit
that referenced
this pull request
Oct 2, 2024
…13850) introduced in the major refactor #13779 Off-heap scoring is only present for byte[] vectors, and it isn't enough to verify that the vector provider also satisfies the HasIndexSlice interface. The vectors need to be byte vectors otherwise, the slice iterations and scoring are completely nonsensical leading to HNSW graph building to run until the heat-death of the universe.
benwtrent
added a commit
that referenced
this pull request
Oct 2, 2024
…13850) introduced in the major refactor #13779 Off-heap scoring is only present for byte[] vectors, and it isn't enough to verify that the vector provider also satisfies the HasIndexSlice interface. The vectors need to be byte vectors otherwise, the slice iterations and scoring are completely nonsensical leading to HNSW graph building to run until the heat-death of the universe.
ChrisHegarty
added a commit
that referenced
this pull request
Oct 2, 2024
ChrisHegarty
added a commit
that referenced
this pull request
Oct 2, 2024
ChrisHegarty
added a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in the major refactor #13779
Off-heap scoring is only present for
byte[]vectors, and it isn't enough to verify that the vector provider also satisfies theHasIndexSliceinterface. The vectors need to be byte vectors otherwise, the slice iterations and scoring are completely nonsensical leading to HNSW graph building to run until the heat-death of the universe.