Add test for float vector values in FlatVectorsScorer impls #13851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
approved these changes
Oct 2, 2024
ChrisHegarty
added a commit
that referenced
this pull request
Oct 2, 2024
ChrisHegarty
added a commit
that referenced
this pull request
Oct 2, 2024
msokolov
reviewed
Oct 2, 2024
|
|
||
| var supplier1 = DEFAULT_SCORER.getRandomVectorScorerSupplier(sim, vectorValues); | ||
| var supplier2 = MEMSEG_SCORER.getRandomVectorScorerSupplier(sim, vectorValues); | ||
| // these assertion assumes that the supplier and scorer's toString will have float |
There was a problem hiding this comment.
too bad we can't access the underlying vector values to see what its vectorEncoding is, but this checking toString() seems sort of OK?
| assertEquals(scorer2.score(0), expected, DELTA); | ||
|
|
||
| expectThrows( | ||
| Throwable.class, |
There was a problem hiding this comment.
Is Throwable the most specific we can assert?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test only change that verifies the behaviour when float vector values are passed to our FlatVectorsScorer implementations. This would have caught the bug causing #13844, subsequently fixed by #13850.