[SUREFIRE-2154] Get rid of localRepository from surefire mojo parameter, use Resolver API

[slawekjaranowski]

• not use org.apache.maven.artifact.repository.ArtifactRepository
• use resolver API

---

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[olamy]

the change is larger than what the description says...
especially dependencies resolves in a different way so jira PR title needs to be updated.
such change can definitely breaks things so it must be correctly described as part of the release notes and corresponding jira/PRs

[slawekjaranowski]

@olamy jira issue updated - any remarks to change?
As we see all ITs pass without changes

[olamy]

ditto this is turning this class into a public API.
Do we really need to publish and support another way of resolving dependencies?
why not simply having some similar private constructor and avoid exposing something else we will have to support.

[slawekjaranowski]

I changed to package private.

The best way will be introduce interface for this component and move implementation to another place
but this class contains a static methods which is used in AbstractSurefireMojo.

So usage is mixed, I would not extends this PR too more.

[olamy]

Thanks!
Not sure why "the best way"? do you plan to introduce alternate implementations?
so no need to introduce interface for a package private class.

[cstamas]

Another example of insane overhead of all legacy stuff: 800 lines less! Great job @slawekjaranowski