-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update airbase to 148 #19607
Update airbase to 148 #19607
Conversation
2d73453
to
ce80fb7
Compare
Fixes incorrect junit/surefire integration that isn't working with the latest surefire plugin. junit-jupiter-engine should be a module dependency, rather then surefire plugin dependency.
ce80fb7
to
6252721
Compare
In these examples, it shows up as a plug-in dependency: https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#api-engine-versions-segregation |
@martint but it doesn't work anymore :( We had it mixed anyway. Some modules were following method in this PR, some were adding engine to the surefire deps. Now it seems to work properly and all transitive dependencies that are needed are resolved (this wasn't the case when the jupiter-engine was in the surefire deps). |
@martint PTAL |
But do we know why it starts failing with the surefire plugin upgrade? That seems like a regression in the plugin, and would suggest we shouldn't update until that bug is fixed. |
@martint I guess that this is related to apache/maven-surefire#617. Anyway I personally think that current behaviour is the correct one. Not the previous one |
@martint I'd like to move forward with this change as it contains some needed dependency upgrades. |
Ping @martint |
How so? It would be preferable to be able to specify the dependencies in the plugin spec so that they could potentially be applied to the whole project eventually by configuring it in the root pom instead. I'm fine with doing this for now if necessary to update the other dependencies you mentioned, but as soon as the underlying bug in surefire is fixed, we should change it back. |
@martint i'm ok with that |
Fixes incorrect junit/surefire integration that isn't working with the latest surefire plugin.
junit-jupiter-engine
should be a module dependency, rather then surefire plugin dependency.