Fix to prevent warning due to CI-friendly version in the parent pom #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to CI-friendly version in the parent pom.
khmarbaise
reviewed
Sep 17, 2018
| @@ -669,6 +669,9 @@ private void initProject( MavenProject project, Map<String, MavenProject> projec | |||
| else | |||
| { | |||
| Artifact parentArtifact = project.getParentArtifact(); | |||
| if (parentArtifact.getVersion().matches("\\$\\{(revision|sha1|changelist)}")) { | |||
| parentArtifact.setVersion(project.getModel().getParent().getVersion()); | |||
There was a problem hiding this comment.
First the pattern is not enough if we really allow to use ci friendly in parent cause things like this ${revision}-${changelist} are also possible which will not work with this pattern..Furthermore an integration test is needed for such things.
|
Unfortunately no reaction. So I close this PR. |
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Nov 20, 2024
* Move ITs to JDK 8 / JUnit 5 * Add missing tests, move disabled test comments to the test itself * Add unreferenced tests (Unreferenced tests are automatically added at the beginning, but it looks more coherent to add them anyway) * Reset verifier to run fresh test in MNG-5581 * Remove useless lines * Minimize changes in imports Co-authored-by: Michael Osipov <michaelo@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue:
https://issues.apache.org/jira/browse/MNG-6455