Move ITs to JDK 8 / JUnit 5 (apache#176)

* Move ITs to JDK 8 / JUnit 5 * Add missing tests, move disabled test comments to the test itself * Add unreferenced tests (Unreferenced tests are automatically added at the beginning, but it looks more coherent to add them anyway) * Reset verifier to run fresh test in MNG-5581 * Remove useless lines * Minimize changes in imports Co-authored-by: Michael Osipov <michaelo@apache.org>
gnodet · Sep 30, 2022 · 6e8ff2d · 6e8ff2d
1 parent 13b14eb
commit 6e8ff2d
Show file tree

Hide file tree

Showing 661 changed files with 3,102 additions and 749 deletions.
diff --git a/its/core-it-suite/pom.xml b/its/core-it-suite/pom.xml
@@ -88,17 +88,10 @@ under the License.
 
   <dependencies>
     <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>4.12</version>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter</artifactId>
       <!-- NOTE: Use compile scope for transitivity. -->
     </dependency>
-    <dependency>
-      <groupId>org.hamcrest</groupId>
-      <artifactId>hamcrest-all</artifactId>
-      <version>1.3</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.codehaus.plexus</groupId>
       <artifactId>plexus-utils</artifactId>
@@ -166,9 +159,10 @@ under the License.
         <artifactId>maven-surefire-plugin</artifactId>
         <configuration>
           <includes>
-            <include>**/IntegrationTestSuite.java</include>
+            <include>**/MavenIT*.java</include>
           </includes>
-          <forkMode>never</forkMode>
+          <forkCount>0</forkCount>
+          <reuseForks>true</reuseForks>
           <skip>true</skip>
           <systemProperties>
             <property>
@@ -318,7 +312,8 @@ under the License.
             <artifactId>maven-surefire-plugin</artifactId>
             <configuration>
               <skip>false</skip>
-              <forkMode>once</forkMode>
+              <forkCount>1</forkCount>
+              <reuseForks>true</reuseForks>
               <argLine>${surefireMemory}
                 -Dcom.sun.management.jmxremote=true</argLine>
               <!-- NOTE: Maven plugins have access to the system class path

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java b/its/core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java
@@ -19,6 +19,7 @@
  * under the License.
  */
 
+import org.junit.jupiter.api.Test;
 import java.io.File;
 import java.io.FileInputStream;
 import java.security.DigestInputStream;

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0008SimplePluginTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0008SimplePluginTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0008SimplePluginTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -41,6 +43,7 @@ public MavenIT0008SimplePluginTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0008()
         throws Exception
     {

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0009GoalConfigurationTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0009GoalConfigurationTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0009GoalConfigurationTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -39,6 +41,7 @@ public MavenIT0009GoalConfigurationTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0009()
         throws Exception
     {

diff --git a/...t-suite/src/test/java/org/apache/maven/it/MavenIT0010DependencyClosureResolutionTest.java b/...t-suite/src/test/java/org/apache/maven/it/MavenIT0010DependencyClosureResolutionTest.java
@@ -25,6 +25,8 @@
 import java.io.File;
 import java.util.List;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0010DependencyClosureResolutionTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -40,6 +42,7 @@ public MavenIT0010DependencyClosureResolutionTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0010()
         throws Exception
     {

diff --git a/...rc/test/java/org/apache/maven/it/MavenIT0011DefaultVersionByDependencyManagementTest.java b/...rc/test/java/org/apache/maven/it/MavenIT0011DefaultVersionByDependencyManagementTest.java
@@ -25,6 +25,8 @@
 import java.io.File;
 import java.util.List;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0011DefaultVersionByDependencyManagementTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -38,6 +40,7 @@ public MavenIT0011DefaultVersionByDependencyManagementTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0011()
         throws Exception
     {

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0012PomInterpolationTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0012PomInterpolationTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0012PomInterpolationTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -37,6 +39,7 @@ public MavenIT0012PomInterpolationTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0012()
         throws Exception
     {

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0018DependencyManagementTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0018DependencyManagementTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0018DependencyManagementTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -39,6 +41,7 @@ public MavenIT0018DependencyManagementTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0018()
         throws Exception
     {

diff --git a/...t-suite/src/test/java/org/apache/maven/it/MavenIT0019PluginVersionMgmtBySuperPomTest.java b/...t-suite/src/test/java/org/apache/maven/it/MavenIT0019PluginVersionMgmtBySuperPomTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0019PluginVersionMgmtBySuperPomTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -37,6 +39,7 @@ public MavenIT0019PluginVersionMgmtBySuperPomTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0019()
         throws Exception
     {

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0021PomProfileTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0021PomProfileTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0021PomProfileTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -38,6 +40,7 @@ public MavenIT0021PomProfileTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0021()
         throws Exception
     {

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0023SettingsProfileTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0023SettingsProfileTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0023SettingsProfileTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -38,6 +40,7 @@ public MavenIT0023SettingsProfileTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0023()
         throws Exception
     {

diff --git a/...ore-it-suite/src/test/java/org/apache/maven/it/MavenIT0024MultipleGoalExecutionsTest.java b/...ore-it-suite/src/test/java/org/apache/maven/it/MavenIT0024MultipleGoalExecutionsTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 /**
  * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-172">MNG-172</a>.
  *
@@ -44,6 +46,7 @@ public MavenIT0024MultipleGoalExecutionsTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0024()
         throws Exception
     {

diff --git a/...suite/src/test/java/org/apache/maven/it/MavenIT0025MultipleExecutionLevelConfigsTest.java b/...suite/src/test/java/org/apache/maven/it/MavenIT0025MultipleExecutionLevelConfigsTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 /**
  * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-172">MNG-172</a>.
  *
@@ -43,6 +45,7 @@ public MavenIT0025MultipleExecutionLevelConfigsTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0025()
         throws Exception
     {

diff --git a/...e-it-suite/src/test/java/org/apache/maven/it/MavenIT0030DepPomDepMgmtInheritanceTest.java b/...e-it-suite/src/test/java/org/apache/maven/it/MavenIT0030DepPomDepMgmtInheritanceTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0030DepPomDepMgmtInheritanceTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -38,6 +40,7 @@ public MavenIT0030DepPomDepMgmtInheritanceTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0030()
         throws Exception
     {

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0032MavenPrerequisiteTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0032MavenPrerequisiteTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0032MavenPrerequisiteTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -37,6 +39,7 @@ public MavenIT0032MavenPrerequisiteTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0032()
         throws Exception
     {

diff --git a/...re-it-suite/src/test/java/org/apache/maven/it/MavenIT0037AlternatePomFileSameDirTest.java b/...re-it-suite/src/test/java/org/apache/maven/it/MavenIT0037AlternatePomFileSameDirTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 /**
  * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-607">MNG-607</a>.
  *
@@ -43,6 +45,7 @@ public MavenIT0037AlternatePomFileSameDirTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0037()
         throws Exception
     {

diff --git a/...-suite/src/test/java/org/apache/maven/it/MavenIT0038AlternatePomFileDifferentDirTest.java b/...-suite/src/test/java/org/apache/maven/it/MavenIT0038AlternatePomFileDifferentDirTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 /**
  * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-607">MNG-607</a>.
  *
@@ -43,6 +45,7 @@ public MavenIT0038AlternatePomFileDifferentDirTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0038()
         throws Exception
     {

diff --git a/...-suite/src/test/java/org/apache/maven/it/MavenIT0040PackagingFromPluginExtensionTest.java b/...-suite/src/test/java/org/apache/maven/it/MavenIT0040PackagingFromPluginExtensionTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 /**
  * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-598">MNG-598</a>.
  *
@@ -44,6 +46,7 @@ public MavenIT0040PackagingFromPluginExtensionTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0040()
         throws Exception
     {

diff --git a/...ite/src/test/java/org/apache/maven/it/MavenIT0041ArtifactTypeFromPluginExtensionTest.java b/...ite/src/test/java/org/apache/maven/it/MavenIT0041ArtifactTypeFromPluginExtensionTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 /**
  * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-598">MNG-598</a>.
  *
@@ -43,6 +45,7 @@ public MavenIT0041ArtifactTypeFromPluginExtensionTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0041()
         throws Exception
     {

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0051ReleaseProfileTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0051ReleaseProfileTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0051ReleaseProfileTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -38,6 +40,7 @@ public MavenIT0051ReleaseProfileTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0051()
         throws Exception
     {

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0052ReleaseProfileTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0052ReleaseProfileTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0052ReleaseProfileTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -38,6 +40,7 @@ public MavenIT0052ReleaseProfileTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0052()
         throws Exception
     {

diff --git a/...ore-it-suite/src/test/java/org/apache/maven/it/MavenIT0056MultipleGoalExecutionsTest.java b/...ore-it-suite/src/test/java/org/apache/maven/it/MavenIT0056MultipleGoalExecutionsTest.java
@@ -24,6 +24,8 @@
 
 import java.io.File;
 
+import org.junit.jupiter.api.Test;
+
 public class MavenIT0056MultipleGoalExecutionsTest
     extends AbstractMavenIntegrationTestCase
 {
@@ -38,6 +40,7 @@ public MavenIT0056MultipleGoalExecutionsTest()
      *
      * @throws Exception in case of failure
      */
+    @Test
     public void testit0056()
         throws Exception
     {