[MNG-5760] Add --resume / -r switch #342

mthmulders · 2020-05-04T15:09:51Z

This pull request adds the --resume / -r switch. It works like --resume-from / -rf, but does more than that:

It takes no arguments. Instead, when a build fails, it creates target/resume.properties which is read when the --resume / -r switch is specified.
It is smarter. When other modules later in the failed build succeeded, they will be excluded from the next (resumed) build. This only happens if there are no dependencies between the former and the latter.

Status

This pull request is a work-in-progress. Not all functionality is finished. We're working on accompanying integration tests.

Pull request checklist

There is a JIRA issue.
Each commit in the pull request has a meaningful subject line and body.
The pull request title is correctly formatted.
The pull request description is detailed enough to understand what the pull request does, how, and why.
Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
You have run the Core IT successfully.

ICLA has been signed by @MartinKanters and myself. CCLA has been signed by our employer, Info Support.

…he next build from.

… with checkstyle rules.

…ume-from suggestion should be given or not.

…he execution request.

…moved to the BuildResumptionManager.

…correctly.

…e next build when it failed after another failed build.

…Maven instead of the CLI. As DefaultMaven has the right info to determine the execution root.

…sult

maven-core/src/main/java/org/apache/maven/DefaultMaven.java

maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java

MartinKanters · 2020-05-25T06:27:13Z

how about a simple canResume() (who knows if there will be other requirements to resume)?

Sounds good, Robert. We will change this name, indeed.

…ture

maven-core/src/main/java/org/apache/maven/DefaultMaven.java

maven-core/src/main/java/org/apache/maven/execution/BuildResumptionManager.java

maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java

maven-core/src/main/java/org/apache/maven/execution/BuildResumptionManager.java

maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionResult.java

…eftover after moving to slf4j.

…a method name.

…ow an exception instead of returning false.

…ether a build can be resumed or not.

…MavenCli. The BuildResumer is now only focused on the --resume feature.

…tead of an optional with a comma separated list

…Repository

…urns void

eolivelli

Great feature
+1

rfscholte · 2020-06-20T13:58:35Z

Fixed in 658ad90

MartinKanters added 11 commits May 4, 2020 16:56

[MNG-5760] When a build fails, write file with properties to resume t…

07b60e4

…he next build from.

[MNG-5760] Refactored the getResumeFromSelector logic to be compliant…

fe48f1b

… with checkstyle rules.

[MNG-5760] Added JavaDoc to the method which determines whether a res…

883d806

…ume-from suggestion should be given or not.

[MNG-5760] Added license to BuildResumptionManagerTest

c467598

[MNG-5760] When -r is given, load resume.properties and apply it to t…

0dc3c0b

…he execution request.

[MNG-5760] Created unit tests for the resumeFromSelector method.

a65ecc3

[MNG-5760] Removed dead code, as the getResumeFrom method has been …

79df2e5

…moved to the BuildResumptionManager.

[MNG-5760] Fix bug where the build resume hint log could be logged in…

8d7f51c

…correctly.

[MNG-5760] Fixed a bug where a failed project would be excluded in th…

fe92235

…e next build when it failed after another failed build.

[MNG-5760] Refactored to call the resumption manager from the Default…

368b60b

…Maven instead of the CLI. As DefaultMaven has the right info to determine the execution root.

[MNG-5760] Removing the resumption data when a build succeeded.

712932d

mthmulders mentioned this pull request May 23, 2020

[MNG-5760] Add integration tests for "resume" feature apache/maven-integration-testing#61

Closed

mthmulders added 2 commits May 23, 2020 19:56

[MNG-5760] Extract public interface

2763ee0

[MNG-5760] Store information about resumption storage in execution re…

7bc1e06

…sult

michael-o requested changes May 23, 2020

View reviewed changes

maven-core/src/main/java/org/apache/maven/DefaultMaven.java Outdated Show resolved Hide resolved

michael-o requested changes May 23, 2020

View reviewed changes

mthmulders mentioned this pull request May 24, 2020

Refactor MavenCli.populateRequest #351

Closed

6 tasks

mthmulders added 5 commits May 25, 2020 15:39

[MNG-5760] Replace Stream#filter#count with Stream#anyMatch

c7fee3f

[MNG-5760] Avoid stringly-typed method signatures

b93dbfd

[MNG-5760] Rename resumptionDataStored to canResume

8bcaa9f

[MNG-5760] Replace Plexus logger with SLF4J

77e5d53

[MNG-5760] Replace String#format with String concatenation

d33702d

mthmulders marked this pull request as ready for review May 25, 2020 15:30

Merge remote-tracking branch 'origin/master' into mng-5760-resume-fea…

40ab881

…ture

rfscholte requested changes Jun 5, 2020

View reviewed changes

MartinKanters added 4 commits June 5, 2020 20:44

[MNG-5760] Renamed BuildResumptionManager to BuildResumer

5a130ea

[MNG-5760] Removed an unused mock for the plexus Logger, which is a l…

7801922

…eftover after moving to slf4j.

[MNG-5760] Resolving review comment; clearing up persistResumptionDat…

5a4a946

…a method name.

[MNG-5760] Review comment: Removed Guava's @VisibleForTesting

557ec1c

MartinKanters and others added 8 commits June 5, 2020 21:21

[MNG-5760] When something fails while persisting resumption data, thr…

08e3a61

…ow an exception instead of returning false.

[MNG-5760] Add a boolean to the setCanResume method, which denotes wh…

c86da3b

…ether a build can be resumed or not.

[MNG-5760] Fixed checkstyle findings

2d5c380

[MNG-5760] Moved the -rf helper method, including the tests, back to …

41faa43

…MavenCli. The BuildResumer is now only focused on the --resume feature.

[MNG-5760] Rename interface and implementation

d87dcbf

[MNG-5760] Refactored #determineProjectsToSkip to return a list ins…

4e35d21

…tead of an optional with a comma separated list

[MNG-5760] Split off BuildResumptionAnalyzer from BuildResumptionData…

9a43e1a

…Repository

[MNG-5760] Persist method either succeeds or throws Exception, so ret…

adf8c6f

…urns void

slachiewicz approved these changes Jun 20, 2020

View reviewed changes

olamy approved these changes Jun 20, 2020

View reviewed changes

[MNG-5760] Removed unused import

058fa9e

eolivelli approved these changes Jun 20, 2020

View reviewed changes

rfscholte closed this Jun 20, 2020

mthmulders mentioned this pull request Jun 21, 2020

[MNG-5760] --resume feature (part 2) #363

Closed

5 tasks

gnodet added a commit to gnodet/maven that referenced this pull request Nov 20, 2024

[MNG-8123] IT for build cache extension (apache#342)

ff1d119

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MNG-5760] Add --resume / -r switch #342

[MNG-5760] Add --resume / -r switch #342

mthmulders commented May 4, 2020 •

edited

Loading

MartinKanters commented May 25, 2020 •

edited

Loading

eolivelli left a comment

rfscholte commented Jun 20, 2020

[MNG-5760] Add --resume / -r switch #342

[MNG-5760] Add --resume / -r switch #342

Conversation

mthmulders commented May 4, 2020 • edited Loading

Status

Pull request checklist

MartinKanters commented May 25, 2020 • edited Loading

eolivelli left a comment

Choose a reason for hiding this comment

rfscholte commented Jun 20, 2020

mthmulders commented May 4, 2020 •

edited

Loading

MartinKanters commented May 25, 2020 •

edited

Loading