Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-5760] --resume feature (part 2) #363

Closed

Conversation

mthmulders
Copy link
Contributor

This pull request is a follow-up on #342, in which two little bugs had sneaked in. Since the feature hasn't been released yet, I haven't added new JIRA tickets for these bugs.

  1. Resolution of resume.properties file didn't work as expected. I have fixed it and added a unit test to illustrate how it should work.
  2. When the excludedProjects property in the resume.properties file was empty, the build would break (since it added an empty project to the list of excluded projects). Of course, this shouldn't happen, so that's fixed too.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles, where you replace MNG-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully. Also, the previously added test case for this feature is now added to the suite.

ICLA has been signed by @MartinKanters and myself. CCLA has been signed by our employer, Info Support.

@mthmulders mthmulders marked this pull request as draft June 21, 2020 11:48
@mthmulders mthmulders marked this pull request as ready for review June 22, 2020 06:53
@MartinKanters
Copy link
Contributor

gnodet added a commit to gnodet/maven that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants