Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized #656

Merged
merged 2 commits into from
Jan 21, 2022
Merged

[3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized #656

merged 2 commits into from
Jan 21, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 12, 2022 •
edited
Loading

@gnodet
Copy link
Contributor Author

gnodet commented Jan 12, 2022

I'll try to backport the test from diffplug/spotless#1074

@gnodet gnodet changed the title [MNG-7386] Make sure the ModelMerger$MergingList can be serialized [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be serialized Jan 17, 2022
@gnodet gnodet requested review from cstamas and michael-o January 19, 2022 15:39
michael-o
michael-o approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, squash, merge to master and maven-3.8.x.

@gnodet gnodet merged commit 0cda424 into apache:maven-3.8.x Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmannibucau rmannibucau rmannibucau approved these changes

@michael-o michael-o michael-o approved these changes

@cstamas cstamas cstamas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnodet @cstamas @michael-o @rmannibucau