Fix fingerprint with deps #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisoft
force-pushed
the
fix_fingerprint_with_deps
branch
from
c2df929 to
a1de999
Compare
|
Thanks for this fix! I will review it today or tomorrow. Tbh, this error is unexpected because |
lutovich
reviewed
Jan 9, 2022
There was a problem hiding this comment.
Looks good, I added two comments. Thanks for discovering and fixing this problem!
I also created a Jira for Maven https://issues.apache.org/jira/browse/MNG-7386.
plugin-maven/src/main/java/com/diffplug/spotless/maven/incremental/PluginFingerprint.java
Show resolved
Hide resolved
plugin-maven/src/test/java/com/diffplug/spotless/maven/incremental/UpToDateCheckingTest.java
Show resolved
Hide resolved
lutovich
approved these changes
Jan 10, 2022
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Maven versions (at least 3.6.3 is affected) use a
org.apache.maven.model.merge.ModelMerger$MergingList, if a plugin is defined insidepluginManagementand additionally defines customdependencies. This class is not serializable, which will fail thePluginFingerprint.This change replaces the dependency list with an
ArrayListbefore serialization and sets it back to the original list afterwards.You can try the demonstrator test without the fix commit, to validate the error.
Fixes: #1073