Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retention 0mb and BacklogQuota 0mb #154

Closed
sschepens opened this issue Dec 26, 2016 · 5 comments
Closed

Retention 0mb and BacklogQuota 0mb #154

sschepens opened this issue Dec 26, 2016 · 5 comments
Assignees
@merlimat
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Milestone
1.22.0-incubating

Comments

@sschepens
Copy link
Contributor

It's not documented what setting a retention of 0mb actually does, neither with BacklogQuota.

By the way, both of this should actually mean no limit to be consistent with other settings.
If i'm not mistaken, setting those to 0mb will make brokers delete all data when they check.

In our case we want a retention based on time and not on size, so we actually want unlimited retention, and probably backlog quota too.
@sschepens
Copy link
Contributor Author

@merlimat what do you think of this? there's now way right now to set an unlimited size retention or backlog quota.
Setting them to 0mb doesn't really make sense.
But if we want to maintain compatibility we could allow -1 as meaning of unlimited or something of the sort.

@merlimat
Copy link
Contributor

Sorry @sschepens, I missed this issue back in the days. I just created #1135 and I'll create another PR to clarify in the documentation

@merlimat merlimat added this to the 1.22.0-incubating milestone Jan 29, 2018
@merlimat merlimat added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Jan 29, 2018
@merlimat merlimat self-assigned this Jan 29, 2018
@merlimat
Copy link
Contributor

Added 2nd PR for docs changes: #1141

@sschepens
Copy link
Contributor Author

Thanks for taking the time!

@merlimat
Copy link
Contributor

Closing since both #1135 & #1140 were merged in 1.22

sijie pushed a commit to sijie/pulsar that referenced this issue Mar 4, 2018
@jerrypeng @sijie
correcting header files (apache#154)
86c8897
hrsakai pushed a commit to hrsakai/pulsar that referenced this issue Dec 10, 2020
@freeznet @merlimat
[Issue apache#153] Fix handler memory leak (apache#154)
4d788d9 
* fix producer handler memory leak

* consumer removed from client handler when closed

* golanglint

* add tests & fix deadlock when handler close

* make handlers delete in closeOnce to prevent unnecessary calls

* goimports
hangc0276 pushed a commit to hangc0276/pulsar that referenced this issue May 26, 2021
@jiazhai
fix advertised address config issue (apache#154)
776bce2 
In Pulsar standalone mode, If advertisedAddress not set, it is hard coded as "localhost":
```
        if (this.getAdvertisedAddress() != null) {
            // Use advertised address from command line
            config.setAdvertisedAddress(this.getAdvertisedAddress());
            zkServers = this.getAdvertisedAddress();
        } else if (isBlank(config.getAdvertisedAddress())) {
            // Use advertised address as local hostname
            config.setAdvertisedAddress("localhost");
        } else {
            // Use advertised address from config file
        }
```

And in KoP, if host address  not set in listeners, it will use advertised address to do the config.
Then the value read from conf.properties is outdated. This PR update it with right value.
@xiaotongwang1 xiaotongwang1 mentioned this issue Aug 4, 2021
Closed
nicoloboschi pushed a commit to nicoloboschi/pulsar that referenced this issue Jan 4, 2023
@aymkhalil
[fix][monitor] Fix reporting pulsar_subscription_blocked_on_unacked_m… (
1bb6ff4 
apache#154)

* [fix][monitor] Fix reporting pulsar_subscription_blocked_on_unacked_messages metric (apache#18621)

* Update the NamespaceStatsAggregatorTest to use SimpleTextOutputStream instead of PrometheusMetricStreams
@ZHr-UChiHa ZHr-UChiHa mentioned this issue Jun 3, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merlimat merlimat

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
1.22.0-incubating
Development

No branches or pull requests
2 participants
@merlimat @sschepens