Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some clarifications on Retention documentation #1141

Merged
merged 1 commit into from
Feb 4, 2018
Merged

Some clarifications on Retention documentation #1141

merged 1 commit into from
Feb 4, 2018

Conversation

merlimat
Copy link
Contributor

Motivation

Tried to simplify here a couple of statements on Retention and added references to infinite retention time as defined in #1135.

@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 29, 2018
@merlimat merlimat added this to the 1.22.0-incubating milestone Jan 29, 2018
@merlimat merlimat self-assigned this Jan 29, 2018
@merlimat merlimat mentioned this pull request Jan 29, 2018
Closed
rdhabalia
rdhabalia approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sschepens
Copy link
Contributor

👍

@merlimat
Copy link
Contributor Author

merlimat commented Feb 3, 2018

retest this please

@merlimat merlimat merged commit 6ed3a49 into apache:master Feb 4, 2018
@merlimat merlimat deleted the retention-docs branch February 4, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdhabalia rdhabalia rdhabalia approved these changes

@sijie sijie Awaiting requested review from sijie

@sschepens sschepens Awaiting requested review from sschepens

@jai1 jai1 Awaiting requested review from jai1

@saandrews saandrews Awaiting requested review from saandrews

@nkurihar nkurihar Awaiting requested review from nkurihar

@yush1ga yush1ga Awaiting requested review from yush1ga

Assignees

@merlimat merlimat

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
1.22.0-incubating
Development

Successfully merging this pull request may close these issues.
3 participants
@merlimat @sschepens @rdhabalia