-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Build fails but Pulsar build passes #238
Comments
merlimat
added
area/test
and removed
type/bug
The PR fixed a bug or issue reported a bug
labels
Mar 3, 2017
@jai1 was this already fixed? |
@merlimat -no will work on it next week |
Only one fix remaining - CPP client crashes on Producer Destruction |
Fixed in #492. Running the c++ build and tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
The Build should fail if C++ clients fails to compile or tests fail
Actual behavior
Build continues since compile steps is a part of after_success and as per documentation
The exit code of after_success, after_failure, after_script and subsequent stages do not affect the build result. However, if one of these stages times out, the build is marked as a failure.
Don't know if it was done deliberately since C++ unit tests are a bit flaky
Steps to reproduce
Checkin incorrect C++ code
System configuration
Pulsar version: x.y
The text was updated successfully, but these errors were encountered: