Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Build fails but Pulsar build passes #238

Closed
jai1 opened this issue Feb 23, 2017 · 4 comments
Closed

C++ Build fails but Pulsar build passes #238

jai1 opened this issue Feb 23, 2017 · 4 comments
Assignees

Comments

@jai1
Copy link
Contributor

jai1 commented Feb 23, 2017

Expected behavior

The Build should fail if C++ clients fails to compile or tests fail

Actual behavior

Build continues since compile steps is a part of after_success and as per documentation

The exit code of after_success, after_failure, after_script and subsequent stages do not affect the build result. However, if one of these stages times out, the build is marked as a failure.

Don't know if it was done deliberately since C++ unit tests are a bit flaky

Steps to reproduce

Checkin incorrect C++ code

System configuration

Pulsar version: x.y

@jai1 jai1 added type/bug The PR fixed a bug or issue reported a bug c++ labels Feb 23, 2017
@jai1 jai1 added this to the 1.17 milestone Feb 23, 2017
@jai1 jai1 self-assigned this Feb 23, 2017
@merlimat merlimat added area/test and removed type/bug The PR fixed a bug or issue reported a bug labels Mar 3, 2017
@merlimat
Copy link
Contributor

@jai1 was this already fixed?

@jai1
Copy link
Contributor Author

jai1 commented Mar 24, 2017

@merlimat -no will work on it next week
The fix is easy but I have noticed that CPP Tests always fail, I don't want to let CPP Test failures hamper the pulsar build.

@jai1 jai1 modified the milestones: 1.18, 1.17 Mar 30, 2017
@jai1
Copy link
Contributor Author

jai1 commented Mar 31, 2017

Only one fix remaining - CPP client crashes on Producer Destruction

@merlimat merlimat modified the milestones: 1.18, 1.19 Jun 15, 2017
@merlimat
Copy link
Contributor

Fixed in #492. Running the c++ build and tests in script sections after java maven build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants