Partitioned consumer test failure #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
reviewed
Mar 30, 2017
| boost::bind(resendMessage, _1, _2, producer)); | ||
| } | ||
| } else { | ||
| producer.sendAsync(MessageBuilder().setProperty("attempt#", boost::lexical_cast<std::string>(attemptNumber + 1)).build(), | ||
| boost::bind(resendMessage, _1, _2, producer)); |
There was a problem hiding this comment.
can't we just write
if (attemptNumber < 3) {
globalResendMessageCount++;
lock.unlock();
}
producer.sendAsync(MessageBuilder().setProperty("attempt#", boost::lexical_cast<std::string>(attemptNumber + 1)).build(),
boost::bind(resendMessage, _1, _2, producer));
saandrews
reviewed
Mar 30, 2017
| @@ -815,6 +826,6 @@ TEST(BasicEndToEndTest, testMessageListenerPause) | |||
|
|
|||
| // 3 seconds | |||
| usleep(3 * 1000 * 1000); | |||
|
|
|||
| Lock lock(mutex_); | |||
There was a problem hiding this comment.
What was the failure without the lock?
There was a problem hiding this comment.
There are two threads using the variable - hence W/O the lock the behavior is undefined.
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
…#323) ### Motivation enable users to configure the logger used by the client and use their own implementation. If no logger is provided, a wrapped `logrus.StandardLogger()` will be used. <s>This PR only solved part of the problem mentioned in the issue https://github.com/apache/pulsar-client-go/issues/228.</s> ### Modifications * define `Logger` and `Entry` interfaces used by the client * add `Logger` field to ClientOptions * add `logger` field to internal structures * provide a logger implementation backed by logrus * implement a no-op logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reduce the number of intermittent test failures before we start work on #238
Modifications
Result