Schema registry #1137
Closed
Schema registry #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 19, 2017 11:07
added 5 commits
March 13, 2018 15:07
# Conflicts: # pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Merged
added 9 commits
March 14, 2018 14:14
sijie
reviewed
Mar 19, 2018
| ); | ||
| return future; | ||
| } | ||
|
|
||
| @NotNull | ||
| private CompletableFuture<LedgerHandle> openLedger(Long ledgerId) { | ||
| final CompletableFuture<LedgerHandle> future = new CompletableFuture<>(); | ||
| bookKeeper.asyncOpenLedger(ledgerId, DigestType.MAC, new byte[]{}, | ||
| bookKeeper.asyncOpenLedger(ledgerId, DigestType.MAC, "".getBytes(Charsets.UTF_8), |
There was a problem hiding this comment.
- make
"".getBytes(Charsets.UTF_8)a constant - use DigestType.CRC32C which is fastest than any other digest types.
There was a problem hiding this comment.
Both of these can be taken from the service configuration.
| @@ -27,6 +27,7 @@ | |||
| import com.google.common.hash.Hashing; | |||
| import com.google.protobuf.ByteString; | |||
| import com.google.protobuf.InvalidProtocolBufferException; | |||
| import java.nio.ByteBuffer; | |||
There was a problem hiding this comment.
nit: the import seems not needed at all?
| ); | ||
|
|
||
| try { | ||
| // validateDestinationExists(destinationName); |
bin/pulsar
Outdated
| @@ -214,6 +214,8 @@ if [ -z "$PULSAR_LOG_CONF" ]; then | |||
| PULSAR_LOG_CONF=$DEFAULT_LOG_CONF | |||
| fi | |||
|
|
|||
| OPTS="-agentlib:jdwp=transport=dt_socket,server=y,address=8000,suspend=n" | |||
There was a problem hiding this comment.
oops, I was debugging something and left this in.
ivankelly
reviewed
Mar 20, 2018
| ); | ||
| return future; | ||
| } | ||
|
|
||
| @NotNull | ||
| private CompletableFuture<LedgerHandle> openLedger(Long ledgerId) { | ||
| final CompletableFuture<LedgerHandle> future = new CompletableFuture<>(); | ||
| bookKeeper.asyncOpenLedger(ledgerId, DigestType.MAC, new byte[]{}, | ||
| bookKeeper.asyncOpenLedger(ledgerId, DigestType.MAC, "".getBytes(Charsets.UTF_8), |
There was a problem hiding this comment.
Both of these can be taken from the service configuration.
| private SchemaType type; | ||
| private long timestamp; | ||
| private String data; | ||
| private Map<String, String> props; |
There was a problem hiding this comment.
any reason for not using full word?
There was a problem hiding this comment.
just (personal) convention. I'm not even consistent... Happy to change.
added 8 commits
March 20, 2018 09:28
- rename props to properties in GetSchemaResponse - Use config for ledger parameters
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/SchemasResource.java # pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java # pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
|
All changes are merged, this tracking ticket can be closed or merged. |
|
awesome work! @mgodave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow users of the system to store the structure and format of the data in a topic
PIP: https://lists.apache.org/thread.html/6f5498bc90526efc44b0725eea0310b9332b4f71b04631233bd4daa1@%3Cdev.pulsar.apache.org%3E