Add JsonIgnore to a few fields in configuration objects #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Problem* We have seen NPE thrown when `ConsumerStats` tries to dump the configuration object with a customized ConsumerEventsListener. The problem came from initialization sequence and when jackson tried to serialize the customized ConsumerEventsListener, it fails with NPE. In general, those customized implementation such as `MessageRouter`, `MessageListener` and `ConsumerEventsListener` are not really needed to serialize as part of json. *Solution* Add @JsonIgnore to those fields to bypass json serialization
|
fyi. this is the logic attempts to dump configuration as json string |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
*Problem* If we assign workerConfig after setting consumer listener, when `ConsumerStats` tries to dump the consumer configuration, it will throw NPE. *Solution* apache#1260 tried to ignore listener fields for json serialization this change focus on avoiding NPE on serializing MembershipManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have seen NPE thrown when
ConsumerStatstries to dump the configuration object with a customized ConsumerEventsListener.The problem came from initialization sequence and when jackson tried to serialize the customized ConsumerEventsListener,
it fails with NPE.
In general, those customized implementation such as
MessageRouter,MessageListenerandConsumerEventsListenerare notreally needed to serialize as part of json.
Solution
Add @JsonIgnore to those fields to bypass json serialization