Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonIgnore to a few fields in configuration objects #1260

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Add JsonIgnore to a few fields in configuration objects #1260

merged 1 commit into from
Feb 21, 2018

Commits on Feb 20, 2018

  1. Add JsonIgnore to a few fields in configuration objects 

    *Problem*

We have seen NPE thrown when `ConsumerStats` tries to dump the configuration object with a customized ConsumerEventsListener.
The problem came from initialization sequence and when jackson tried to serialize the customized ConsumerEventsListener,
it fails with NPE.

In general, those customized implementation such as `MessageRouter`, `MessageListener` and `ConsumerEventsListener` are not
really needed to serialize as part of json.

*Solution*

Add @JsonIgnore to those fields to bypass json serialization
    @sijie
    sijie committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    519590f View commit details
    Browse the repository at this point in the history