-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Persistent Topics v3 API - use custom media type instead #14117
Conversation
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but we should find a way to clearly document this in the documentation
maybe swagger is already well documenting this new media type?
could you please verify ?
…he#14117) * Remove Persistent Topics v3 API - use custom media type instead * Don't pass properties if there are none * Cleanup remains of topicV3, use old API method when no properties are set * Fix tests
@eolivelli Swagger distinguishes endpoints by verb + path only. It can be a docs issue, see also #18947. |
Fixes #14104
Motivation
The challenge seems to be that in the old method, the number of partitions was passed in the payload as a single integer without having a JSON object at all. This makes it harder to extend the existing API, but doesn’t make it impossible.
Content-Type: application/vnd.partitioned-topic-metadata+json
on request,@Consumes("application/vnd.partitioned-topic-metadata+json")
on method that handles the new payload type.Modifications
application/vnd.partitioned-topic-metadata+json
to distinguish the new content payload type