-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] ExtNonPersistentTopics and prevent prefix match #19065
Conversation
Signed-off-by: tison <wander4096@gmail.com>
0f28be0
to
3794711
Compare
Verified with |
try { | ||
validateNamespaceName(tenant, namespace); | ||
validateGlobalNamespaceOwnership(); | ||
validateTopicName(tenant, namespace, encodedTopic); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #19065 +/- ##
============================================
+ Coverage 47.11% 47.37% +0.26%
- Complexity 10595 10711 +116
============================================
Files 710 711 +1
Lines 69423 69454 +31
Branches 7449 7452 +3
============================================
+ Hits 32709 32907 +198
+ Misses 33037 32877 -160
+ Partials 3677 3670 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/ExtNonPersistentTopics.java
Outdated
Show resolved
Hide resolved
…ExtNonPersistentTopics.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging... |
…#19065) Signed-off-by: tison <wander4096@gmail.com>
This is a follow-up to #19025. That the swagger plugin is matching by prefix so we have to distinguish the class name in prefix.
Also add back the inherit logic for
NonPersistentTopics
and fix a bug inline.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: