Fix file descriptor leak on LinuxBrokerHostUsageImpl #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Jan 30, 2017
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Modifications Fix concurrent map read and map write
zzzming
pushed a commit
to zzzming/pulsar
that referenced
this pull request
Jun 5, 2023
michaeljmarshall
pushed a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Apr 4, 2024
(cherry picked from commit e2e2c4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LinuxBrokerHostUsageImpl is leaking file descriptors when reading
/proc/statsand when reading files in/sys/class/net.It's counter-intuitive, but java file streams must be closed, reference.
Modifications
Stream now are opened using try-with-resource.
Result
There should be no more file descriptor leaks.