Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file descriptor leak on LinuxBrokerHostUsageImpl #179

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Fix file descriptor leak on LinuxBrokerHostUsageImpl #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...oker/src/main/java/com/yahoo/pulsar/broker/loadbalance/impl/LinuxBrokerHostUsageImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.util.List;
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;
import java.util.stream.Stream;

/**
* Class that will return the broker host usage.
Expand Down Expand Up @@ -120,8 +121,8 @@ private double getTotalCpuLimit() {
* this would include iowait, irq and steal.
*/
private CpuStat getTotalCpuUsage() {
try {
String[] words = Files.lines(Paths.get("/proc/stat"))
try (Stream<String> stream = Files.lines(Paths.get("/proc/stat"))) {
String[] words = stream
.findFirst()
.get().split("\\s+");

Expand All @@ -146,8 +147,8 @@ private ResourceUsage getMemUsage() {
}

private List<String> getNics() {
try {
return Files.list(Paths.get("/sys/class/net/"))
try (Stream<Path> stream = Files.list(Paths.get("/sys/class/net/"))) {
return stream
.filter(this::isPhysicalNic)
.map(path -> path.getFileName().toString())
.collect(Collectors.toList());
Expand Down