[improve][test] Remove conscrypt exception stacktrace in Apple silicon #18359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
reviewed
Nov 7, 2022
| @@ -124,7 +124,12 @@ private static Provider loadConscryptProvider() { | |||
| conscryptClazz = Class.forName("org.conscrypt.Conscrypt"); | |||
| conscryptClazz.getMethod("checkAvailability").invoke(null); | |||
| } catch (Throwable e) { | |||
| log.warn("Conscrypt isn't available. Using JDK default security provider.", e); | |||
| if (e.getCause() != null && e.getCause().getClass().getName().equals("java.lang.UnsatisfiedLinkError")) { | |||
There was a problem hiding this comment.
Could we use debug instead of warn?
There was a problem hiding this comment.
It's better to use level warn because it is a exception — not a If - else or something needs to record. This warn means conscrypt is not supported which needs to remind.
There was a problem hiding this comment.
If you want to avoid the too-long message, I suggest you just output the message and then add a debug log to print the stack trace.
poorbarcode
approved these changes
Nov 7, 2022
coderzc
reviewed
Nov 7, 2022
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java
Outdated
Show resolved
Hide resolved
…rityUtility.java Co-authored-by: Cong Zhao <zhaocong@apache.org>
codelipenghui
added
type/enhancement
codelipenghui
approved these changes
Nov 16, 2022
|
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18359 +/- ##
============================================
+ Coverage 40.29% 47.91% +7.62%
- Complexity 8685 9352 +667
============================================
Files 687 613 -74
Lines 67441 58391 -9050
Branches 7225 6087 -1138
============================================
+ Hits 27175 27979 +804
+ Misses 37257 27386 -9871
- Partials 3009 3026 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tisonkun
approved these changes
Nov 16, 2022
| @@ -124,7 +124,12 @@ private static Provider loadConscryptProvider() { | |||
| conscryptClazz = Class.forName("org.conscrypt.Conscrypt"); | |||
| conscryptClazz.getMethod("checkAvailability").invoke(null); | |||
| } catch (Throwable e) { | |||
| log.warn("Conscrypt isn't available. Using JDK default security provider.", e); | |||
| if (e.getCause() instanceof UnsatisfiedLinkError) { | |||
There was a problem hiding this comment.
@codelipenghui @nodece Do we have an exception util like Flink's findThrowable? I'm afraid that the error may be changed to differ wrap level.
|
/pulsarbot run-failure-checks |
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When running tests in Macos Apple silicon, there will be a long stacktrace like this
There's no osx aarch_64 conscrypt, so we can filter this stacktrace by catching
java.lang.UnsatisfiedLinkError.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/yaalsn/pulsar/pull/16