Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Remove conscrypt exception stacktrace in Apple silicon #18359

Merged
merged 5 commits into from
Nov 19, 2022
Merged

[improve][test] Remove conscrypt exception stacktrace in Apple silicon #18359

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cebe36c
[improve][test] Simplify conscrypt warn log when using unsupported os…
yaalsn Nov 4, 2022
1e7b698
[improve][test] Simplify conscrypt warn log when using unsupported os…
yaalsn Nov 4, 2022
8a45eac
[improve][test] Simplify conscrypt warn log when using unsupported os…
yaalsn Nov 4, 2022
3516727
[improve][test] Simplify conscrypt warn log when using unsupported os…
yaalsn Nov 4, 2022
d96b604
Update pulsar-common/src/main/java/org/apache/pulsar/common/util/Secu…
yaalsn Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,12 @@ private static Provider loadConscryptProvider() {
conscryptClazz = Class.forName("org.conscrypt.Conscrypt");
conscryptClazz.getMethod("checkAvailability").invoke(null);
} catch (Throwable e) {
log.warn("Conscrypt isn't available. Using JDK default security provider.", e);
if (e.getCause() != null && e.getCause().getClass().getName().equals("java.lang.UnsatisfiedLinkError")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use debug instead of warn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use level warn because it is a exception — not a If - else or something needs to record. This warn means conscrypt is not supported which needs to remind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to avoid the too-long message, I suggest you just output the message and then add a debug log to print the stack trace.

yaalsn marked this conversation as resolved.
Show resolved Hide resolved
log.warn("Conscrypt isn't available for {} {}. Using JDK default security provider.",
System.getProperty("os.name"), System.getProperty("os.arch"));
} else {
log.warn("Conscrypt isn't available. Using JDK default security provider.", e);
}
return null;
}

Expand Down