Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] [broker] remove useless argument for PersistentTopicBase.internalSkipAllMessagesForNonPartitionedTopicAsync #18473

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

poorbarcode
Copy link
Contributor

Motivation

The authoritative parameter of method PersistentTopicBase.internalSkipAllMessagesForNonPartitionedTopicAsync is no longer useful.

Modifications

remove useless arguments for PersistentTopicBase.internalSkipAllMessagesForNonPartitionedTopicAsync.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

…ternalSkipAllMessagesForNonPartitionedTopicAsync
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 15, 2022
@nodece nodece added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/broker labels Nov 15, 2022
@nodece nodece added this to the 2.12.0 milestone Nov 15, 2022
@nodece
Copy link
Member

nodece commented Nov 15, 2022

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #18473 (0612c9b) into master (fdf86d3) will increase coverage by 0.02%.
The diff coverage is 10.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18473      +/-   ##
============================================
+ Coverage     45.67%   45.69%   +0.02%     
- Complexity    10075    10078       +3     
============================================
  Files           693      697       +4     
  Lines         67940    67981      +41     
  Branches       7273     7278       +5     
============================================
+ Hits          31030    31065      +35     
- Misses        33333    33340       +7     
+ Partials       3577     3576       -1     
Flag Coverage Δ
unittests 45.69% <10.20%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adbalance/extensions/channel/ServiceUnitState.java 0.00% <0.00%> (ø)
...lance/extensions/channel/ServiceUnitStateData.java 0.00% <0.00%> (ø)
...ar/broker/loadbalance/extensions/models/Split.java 0.00% <0.00%> (ø)
...r/broker/loadbalance/extensions/models/Unload.java 0.00% <0.00%> (ø)
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 15.03% <0.00%> (-0.07%) ⬇️
...a/org/apache/pulsar/client/impl/MessageIdImpl.java 80.55% <33.33%> (+18.05%) ⬆️
...apache/pulsar/client/impl/ConsumerBuilderImpl.java 27.80% <50.00%> (+0.29%) ⬆️
...pulsar/broker/admin/impl/PersistentTopicsBase.java 58.95% <100.00%> (-0.28%) ⬇️
.../apache/pulsar/broker/admin/impl/PackagesBase.java 54.12% <0.00%> (-13.77%) ⬇️
...ce/schema/validator/StructSchemaDataValidator.java 52.38% <0.00%> (-9.53%) ⬇️
... and 37 more

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

1 similar comment
@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- merged commit 080213b into apache:master Nov 18, 2022
@poorbarcode poorbarcode deleted the cleanup/skip_all_msgs branch November 18, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants