Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] [broker] remove useless argument for PersistentTopicBase.internalSkipAllMessagesForNonPartitionedTopicAsync #18473

Merged
merged 1 commit into from
Nov 18, 2022
Merged

[cleanup] [broker] remove useless argument for PersistentTopicBase.internalSkipAllMessagesForNonPartitionedTopicAsync #18473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1897,7 +1897,7 @@ protected void internalSkipAllMessages(AsyncResponse asyncResponse, String subNa
.thenCompose(__ -> {
// If the topic name is a partition name, no need to get partition topic metadata again
if (topicName.isPartitioned()) {
return internalSkipAllMessagesForNonPartitionedTopicAsync(asyncResponse, subName, authoritative);
return internalSkipAllMessagesForNonPartitionedTopicAsync(asyncResponse, subName);
} else {
return getPartitionedTopicMetadataAsync(topicName,
authoritative, false).thenCompose(partitionMetadata -> {
Expand Down Expand Up @@ -1938,8 +1938,7 @@ protected void internalSkipAllMessages(AsyncResponse asyncResponse, String subNa
return null;
});
} else {
return internalSkipAllMessagesForNonPartitionedTopicAsync(asyncResponse, subName,
authoritative);
return internalSkipAllMessagesForNonPartitionedTopicAsync(asyncResponse, subName);
}
});
}
Expand All @@ -1955,8 +1954,7 @@ protected void internalSkipAllMessages(AsyncResponse asyncResponse, String subNa
}

private CompletableFuture<Void> internalSkipAllMessagesForNonPartitionedTopicAsync(AsyncResponse asyncResponse,
String subName,
boolean authoritative) {
String subName) {
return getTopicReferenceAsync(topicName).thenCompose(t -> {
PersistentTopic topic = (PersistentTopic) t;
BiConsumer<Void, Throwable> biConsumer = (v, ex) -> {
Expand Down