Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][client] Revert "[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout #18475

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Nov 15, 2022

Motivation

#17318 has made internalRedeliverUnacknowledgedMessages executed by internalPinnedExecutor which may cause a deadlock described in #18462.
So revert this patch and decide to close #18462.

Modification

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…not filtered when using batch receive and trigger timeout. (apache#17318)"

This reverts commit 12e78b2.
@Technoboy- Technoboy- self-assigned this Nov 15, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Nov 15, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 15, 2022
@Technoboy- Technoboy- changed the title Revert "[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout [improve][client] Revert "[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout Nov 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #18475 (3a9dcdc) into master (fdf86d3) will decrease coverage by 11.74%.
The diff coverage is 3.61%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18475       +/-   ##
=============================================
- Coverage     45.67%   33.92%   -11.75%     
+ Complexity    10075     6430     -3645     
=============================================
  Files           693      617       -76     
  Lines         67940    58522     -9418     
  Branches       7273     6106     -1167     
=============================================
- Hits          31030    19856    -11174     
- Misses        33333    36046     +2713     
+ Partials       3577     2620      -957     
Flag Coverage Δ
unittests 33.92% <3.61%> (-11.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adbalance/extensions/channel/ServiceUnitState.java 0.00% <0.00%> (ø)
...lance/extensions/channel/ServiceUnitStateData.java 0.00% <0.00%> (ø)
...ar/broker/loadbalance/extensions/models/Split.java 0.00% <0.00%> (ø)
...r/broker/loadbalance/extensions/models/Unload.java 0.00% <0.00%> (ø)
...ulsar/broker/loadbalance/impl/OverloadShedder.java 6.12% <0.00%> (+0.24%) ⬆️
...r/client/impl/UnAckedMessageRedeliveryTracker.java 0.00% <0.00%> (ø)
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 14.80% <1.47%> (-0.30%) ⬇️
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java 22.26% <2.94%> (-0.70%) ⬇️
...va/org/apache/pulsar/client/impl/ConsumerBase.java 21.95% <33.33%> (ø)
...a/org/apache/pulsar/client/impl/MessageIdImpl.java 80.55% <33.33%> (+18.05%) ⬆️
... and 238 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants