[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout #18478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18478 +/- ##
============================================
+ Coverage 47.15% 47.21% +0.06%
- Complexity 10432 10440 +8
============================================
Files 697 698 +1
Lines 68023 67986 -37
Branches 7284 7271 -13
============================================
+ Hits 32074 32101 +27
+ Misses 32367 32306 -61
+ Partials 3582 3579 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
force-pushed
the
fix-17318
branch
from
23fb813 to
07cd25c
Compare
shibd
reviewed
Nov 15, 2022
| clearIncomingMessages(); | ||
| unAckedMessageTracker.clear(); | ||
| int currentSize; | ||
| synchronized (incomingQueueLock) { |
There was a problem hiding this comment.
It seems that locks still need to be used. if use share sub, may we don't need this lock.
Original comment: #17318 (comment)
Related modifications: f2d6b47
shibd
approved these changes
Nov 16, 2022
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 18, 2022
|
@Technoboy- Please help resolve the conflicts |
…g batch receive and trigger timeout
Technoboy-
force-pushed
the
fix-17318
branch
from
e2ddd2c to
61cff54
Compare
Done |
congbobo184
reviewed
Nov 20, 2022
Comment on lines
+851
to
+853
| incomingQueueLock.lock(); | ||
| try { | ||
| if (canEnqueueMessage(message) && incomingMessages.offer(message)) { |
There was a problem hiding this comment.
add lock but don't check the epoch, it also can't filter the message that the epoch is smaller than the current epoch, right? @Technoboy- @codelipenghui
There was a problem hiding this comment.
+1, here need add judge isValidConsumerEpoch(message)
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
…ered when using batch receive and trigger timeout (apache#18478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The original patch is #17318. Revert by #18475
Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.
Modifications
notifyPendingBatchReceivedCallBack.notifyPendingBatchReceivedCallBacklogic.Verifying this change
testBatchReceiveRedeliveryAddEpochunit test covers the scene.Documentation
doc-not-needed