[fix][test] Fix some resource leaks in compaction tests #21374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
Technoboy-,
tisonkun,
coderzc,
mattisonchao and
heesung-sn
tisonkun
approved these changes
Oct 17, 2023
Technoboy-
approved these changes
Oct 17, 2023
Demogorgon314
approved these changes
Oct 17, 2023
lhotari
added a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit e6cd11f)
lhotari
added a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit e6cd11f) # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit e6cd11f)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit e6cd11f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are some resource leaks in compaction tests when the bookkeeper client isn't closed.
Modifications
Close the bookkeeper client.
Documentation
docdoc-requireddoc-not-neededdoc-complete