[fix][test] Fix some resource leaks in compaction tests (apache#21374)

(cherry picked from commit e6cd11f)
datastax · Dec 20, 2023 · 85e9436 · 85e9436
1 parent 16b8c87
commit 85e9436
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java
@@ -161,6 +161,7 @@ public void cleanup() throws Exception {
 
     @Test
     public void testEntryLookup() throws Exception {
+        @Cleanup
         BookKeeper bk = pulsar.getBookKeeperClientFactory().create(
                 this.conf, null, null, Optional.empty(), null);
 
@@ -216,6 +217,7 @@ public void testEntryLookup() throws Exception {
 
     @Test
     public void testCleanupOldCompactedTopicLedger() throws Exception {
+        @Cleanup
         BookKeeper bk = pulsar.getBookKeeperClientFactory().create(
                 this.conf, null, null, Optional.empty(), null);
 
@@ -845,6 +847,7 @@ public void testReadCompactedLatestMessageWithInclusive() throws Exception {
 
     @Test
     public void testCompactWithConcurrentGetCompactionHorizonAndCompactedTopicContext() throws Exception {
+        @Cleanup
         BookKeeper bk0 = pulsar.getBookKeeperClientFactory().create(
                 this.conf, null, null, Optional.empty(), null);
 

diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java
@@ -168,7 +168,7 @@ public void setup() throws Exception {
     @Override
     public void cleanup() throws Exception {
         super.internalCleanup();
-
+        bk.close();
         if (compactionScheduler != null) {
             compactionScheduler.shutdownNow();
         }