Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) #22223

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Mar 8, 2024

Motivation

Cherry-pick #20990 to branch-2.10

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@nodece nodece self-assigned this Mar 8, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 8, 2024
@nodece nodece added type/bug The PR fixed a bug or issue reported a bug release/2.7.6 release/2.10.7 and removed doc-not-needed Your PR changes do not impact docs release/2.7.6 labels Mar 8, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 8, 2024
@nodece
Copy link
Member Author

nodece commented Mar 8, 2024

/pulsarbot rerun-failure-checks

@gaoran10 gaoran10 requested a review from Technoboy- March 8, 2024 19:16
@nodece
Copy link
Member Author

nodece commented Mar 12, 2024

@lhotari Do you have any suggestions about com.github.dockerjava.api.exception.DockerClientException: Could not pull image: failed to register layer: write /u01/app/oracle-product/12.2.0/SE/suptools/orachk/collections.dat: no space left on device?

@lhotari
Copy link
Member

lhotari commented Mar 12, 2024

@lhotari Do you have any suggestions about com.github.dockerjava.api.exception.DockerClientException: Could not pull image: failed to register layer: write /u01/app/oracle-product/12.2.0/SE/suptools/orachk/collections.dat: no space left on device?

@nodece where did that happen?

@nodece
Copy link
Member Author

nodece commented Mar 12, 2024

@Technoboy- Technoboy- merged commit 2c85dd1 into apache:branch-2.10 Mar 14, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs release/2.10.7 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants