WebService refactoring #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry argument in the constructor.
Little WebService refactor, removing magic values, removing unnecessa…
|
CLA is valid! |
agarman
reviewed
Sep 27, 2016
| tlsConnector.setHost(pulsar.getBindAddress()); | ||
| connectors.add(tlsConnector); | ||
| } | ||
|
|
||
| // Limit number of concurrent HTTP connections to avoid getting out of file descriptors | ||
| connectors.stream().forEach(c -> c.setAcceptQueueSize(1024 / connectors.size())); | ||
| connectors.stream().forEach(c -> c.setAcceptQueueSize(WebService.MAX_CONCURRENT_REQUESTES / connectors.size())); |
There was a problem hiding this comment.
While in here... is there a good reason for connectors.stream().forEach vs. just using connectors.forEach
There was a problem hiding this comment.
Indeed. Also the line below, as we're iterating over the connectors, while not to call server.addConnector(c)?
Removing more code.
|
Apologies, fix coming, seems one can't simply |
Turns out one can't simply addConnector...
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
Upgrade pulsar to 2.4.0
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
- Add some test cases for KafkaRequestHandler. fix error in the tests. - change handleListOffsetRequest to get topic offset from PersistentTopic directly instead of calling admin command to get topic stats. - In topicManager add a Map to cache PersistentTopic.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clarifying the code in the
WebService.Modifications
Removes the unnecessary argument in the constructor.
Removes magic values.
Result
No functional changes.