Revise null check of ServiceConfigureUtils #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
yush1ga
force-pushed
the
revise_nullcheck
branch
from
c03cfe1
to
0b29be4
Compare
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
added note for pulsar-client-dev rather than pulsar-client
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
This PR is adding Security within KoP. All auth is forwarded to Pulsar's auth mechanisms. This PR is also adding the support of SASL_PLAIN to inject the auth: user correspond to the namespace password corresponds to the authorization provider and the authorization payload
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
…opicx (apache#50) In PR apache#47, there is a change to return kafka client with pulsar format topic, This is a change mainly to revert the return of topic name from `persistent://tent/ns/topicx` back to `topicx`. Also added a unit-test for this. Some minor changes, besides this main change: - fix log level when parse listeners port. - change default log4j2 log level from debug to info. - fix assert from ledgeId > 0 to ledgerId >= 0. - add a test for message order. ======== * fix log level for listeners port get * change default log level in log4j2 * fix assert from ledgeId > 0 to ledgerId >= 0 * add a test to check message order * revert the return of topic name from persistent://tent/ns/topicx to topicx * add test for metadata request handling * fix checkstyle * mv utils from request handler to file TopicNameUtils
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Mar 29, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
getDefaultOrConfiguredAddress method in ServiceConfigurationUtils class returns blank string when configuredAddress is blank.
Modifications
The method had only null check.
I changed it to blank check.
Result
The method returns localhost address when configuredAddress is blank.