Handle concurrent open cursor requests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
1 similar comment
|
CLA is valid! |
rdhabalia
reviewed
Oct 6, 2016
| // Update the ack position (ignoring entries that were written while the cursor was being created) | ||
| cursor.initializeCursorPosition(getLastPositionAndCounter()); | ||
|
|
||
| synchronized (this) { |
There was a problem hiding this comment.
Now, as we are sure that only one thread calls cursor.initialize(..) then should we need synchronized here?
There was a problem hiding this comment.
But another thread will be accessing uninitializedCursors, so we will need it to be synchronized
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
Change first release version to 1.0.0
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Fixes apache#49 Motivation By default, timeout exit after 10 minutes go test --help -timeout d If a test binary runs longer than duration d, panic. If d is 0, the timeout is disabled. The default is 10 minutes (10m).
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
…opicx (apache#50) In PR apache#47, there is a change to return kafka client with pulsar format topic, This is a change mainly to revert the return of topic name from `persistent://tent/ns/topicx` back to `topicx`. Also added a unit-test for this. Some minor changes, besides this main change: - fix log level when parse listeners port. - change default log4j2 log level from debug to info. - fix assert from ledgeId > 0 to ledgerId >= 0. - add a test for message order. ======== * fix log level for listeners port get * change default log level in log4j2 * fix assert from ledgeId > 0 to ledgerId >= 0 * add a test to check message order * revert the return of topic name from persistent://tent/ns/topicx to topicx * add test for metadata request handling * fix checkstyle * mv utils from request handler to file TopicNameUtils
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the Managed Ledger gets concurrent open cursor requests for the same cursor, 1 request fails with Cursor already exists exception.
Modifications
Any cursor that is uninitialized will be reused for the next open cursor request using a Completable Future for the cursor, so that it doesn't try to create a new cursor.
Result
Managed Ledger will be able to handle concurrent open cursor requests properly.