Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integeration-test]Fix integration-test failed when execute pip3 install pulsar_client #4754

Merged
merged 3 commits into from
Jul 18, 2019

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Jul 18, 2019

Fix #4748 (comment)

Motivation

When installing the pulsar-client-2.5.0 using the image openjdk:8-jdk-slim, for Debian 10 systems, python3.7 will be installed when apt-get install python3 is executed. When installing the client using pip3, the following exception will be thrown

cat /etc/issue
Debian GNU/Linux 10 \n \l

root@40fdedf3f3c3:/# python3
Python 3.7.3 (default, Apr  3 2019, 05:39:12)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>

root@40fdedf3f3c3:/# pip3 install pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl
ERROR: pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl is not a supported wheel on this platform.

Modification

Install Use pip3.5 instead of pip3.

When installing the pulsar-client-2.5.0 using the image openjdk:8-jdk-slim, for debian 10 systems, python3.7 will be installed when apt-get install python3 is executed. When installing the client using pip3, the following exception will be thrown
```
cat /etc/issue
Debian GNU/Linux 10 \n \l

root@40fdedf3f3c3:/# python3
Python 3.7.3 (default, Apr  3 2019, 05:39:12)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>

root@40fdedf3f3c3:/# pip3 install pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl
ERROR: pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl is not a supported wheel on this platform.
```

### Modifications

Install Use pip3.5 instead of pip3.
@sijie
Copy link
Member

sijie commented Jul 18, 2019

run java8 tests

@sijie sijie added area/build type/bug The PR fixed a bug or issue reported a bug labels Jul 18, 2019
@sijie sijie added this to the 2.4.1 milestone Jul 18, 2019
@tuteng
Copy link
Member Author

tuteng commented Jul 18, 2019

run java8 tests

@sijie
Copy link
Member

sijie commented Jul 18, 2019

run java8 tests

@tuteng
Copy link
Member Author

tuteng commented Jul 18, 2019

run java8 tests

Copy link
Contributor

@massakam massakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@massakam massakam merged commit 0a59b4c into apache:master Jul 18, 2019
@sijie sijie deleted the fix/python-client-support-3.5 branch July 18, 2019 15:41
easyfan pushed a commit to easyfan/pulsar that referenced this pull request Jul 26, 2019
…all pulsar_client (apache#4754)

* ### Motivation
When installing the pulsar-client-2.5.0 using the image openjdk:8-jdk-slim, for debian 10 systems, python3.7 will be installed when apt-get install python3 is executed. When installing the client using pip3, the following exception will be thrown
```
cat /etc/issue
Debian GNU/Linux 10 \n \l

root@40fdedf3f3c3:/# python3
Python 3.7.3 (default, Apr  3 2019, 05:39:12)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>

root@40fdedf3f3c3:/# pip3 install pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl
ERROR: pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl is not a supported wheel on this platform.
```

### Modifications

Install Use pip3.5 instead of pip3.

* Deleute no used tools

* Fix Docker command
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
…all pulsar_client (#4754)

* ### Motivation
When installing the pulsar-client-2.5.0 using the image openjdk:8-jdk-slim, for debian 10 systems, python3.7 will be installed when apt-get install python3 is executed. When installing the client using pip3, the following exception will be thrown
```
cat /etc/issue
Debian GNU/Linux 10 \n \l

root@40fdedf3f3c3:/# python3
Python 3.7.3 (default, Apr  3 2019, 05:39:12)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>

root@40fdedf3f3c3:/# pip3 install pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl
ERROR: pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl is not a supported wheel on this platform.
```

### Modifications

Install Use pip3.5 instead of pip3.

* Deleute no used tools

* Fix Docker command

(cherry picked from commit 0a59b4c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Tests failing
3 participants