-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integeration-test]Fix integration-test failed when execute pip3 install pulsar_client #4754
Merged
massakam
merged 3 commits into
apache:master
from
AmateurEvents:fix/python-client-support-3.5
Jul 18, 2019
Merged
[Integeration-test]Fix integration-test failed when execute pip3 install pulsar_client #4754
massakam
merged 3 commits into
apache:master
from
AmateurEvents:fix/python-client-support-3.5
Jul 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing the pulsar-client-2.5.0 using the image openjdk:8-jdk-slim, for debian 10 systems, python3.7 will be installed when apt-get install python3 is executed. When installing the client using pip3, the following exception will be thrown ``` cat /etc/issue Debian GNU/Linux 10 \n \l root@40fdedf3f3c3:/# python3 Python 3.7.3 (default, Apr 3 2019, 05:39:12) [GCC 8.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> root@40fdedf3f3c3:/# pip3 install pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl ERROR: pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl is not a supported wheel on this platform. ``` ### Modifications Install Use pip3.5 instead of pip3.
run java8 tests |
sijie
approved these changes
Jul 18, 2019
run java8 tests |
run java8 tests |
run java8 tests |
massakam
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
…all pulsar_client (apache#4754) * ### Motivation When installing the pulsar-client-2.5.0 using the image openjdk:8-jdk-slim, for debian 10 systems, python3.7 will be installed when apt-get install python3 is executed. When installing the client using pip3, the following exception will be thrown ``` cat /etc/issue Debian GNU/Linux 10 \n \l root@40fdedf3f3c3:/# python3 Python 3.7.3 (default, Apr 3 2019, 05:39:12) [GCC 8.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> root@40fdedf3f3c3:/# pip3 install pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl ERROR: pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl is not a supported wheel on this platform. ``` ### Modifications Install Use pip3.5 instead of pip3. * Deleute no used tools * Fix Docker command
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
…all pulsar_client (#4754) * ### Motivation When installing the pulsar-client-2.5.0 using the image openjdk:8-jdk-slim, for debian 10 systems, python3.7 will be installed when apt-get install python3 is executed. When installing the client using pip3, the following exception will be thrown ``` cat /etc/issue Debian GNU/Linux 10 \n \l root@40fdedf3f3c3:/# python3 Python 3.7.3 (default, Apr 3 2019, 05:39:12) [GCC 8.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> root@40fdedf3f3c3:/# pip3 install pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl ERROR: pulsar_client-2.5.0-cp35-cp35m-manylinux1_x86_64.whl is not a supported wheel on this platform. ``` ### Modifications Install Use pip3.5 instead of pip3. * Deleute no used tools * Fix Docker command (cherry picked from commit 0a59b4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4748 (comment)
Motivation
When installing the pulsar-client-2.5.0 using the image openjdk:8-jdk-slim, for Debian 10 systems, python3.7 will be installed when
apt-get install python3
is executed. When installing the client using pip3, the following exception will be thrownModification
Install Use pip3.5 instead of pip3.