[issue 7851][C++] Make clear() thread-safe #7862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
|
Seems that there's something wrong with |
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Aug 21, 2020
jiazhai
approved these changes
Aug 23, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#7851 ### Motivation `clear()` methods of `BatchAcknowledgementTracker` and `UnAckedMessageTrackerEnabled` are not thread-safe. ### Modifications Acquire a mutex in these `clear()` methods.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7851 ### Motivation `clear()` methods of `BatchAcknowledgementTracker` and `UnAckedMessageTrackerEnabled` are not thread-safe. ### Modifications Acquire a mutex in these `clear()` methods.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7851 ### Motivation `clear()` methods of `BatchAcknowledgementTracker` and `UnAckedMessageTrackerEnabled` are not thread-safe. ### Modifications Acquire a mutex in these `clear()` methods.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7851 ### Motivation `clear()` methods of `BatchAcknowledgementTracker` and `UnAckedMessageTrackerEnabled` are not thread-safe. ### Modifications Acquire a mutex in these `clear()` methods.
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
Oct 16, 2020
Fixes apache#7851 ### Motivation `clear()` methods of `BatchAcknowledgementTracker` and `UnAckedMessageTrackerEnabled` are not thread-safe. ### Modifications Acquire a mutex in these `clear()` methods. (cherry picked from commit 97f4112)
|
already merged into branch-2.6: |
wolfstudy
added a commit
that referenced
this pull request
Oct 30, 2020
This reverts commit 9d02404.
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7851
Motivation
clear()methods ofBatchAcknowledgementTrackerandUnAckedMessageTrackerEnabledare not thread-safe.Modifications
Acquire a mutex in these
clear()methods.