Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Message at the end of a file may never be uploaded if last commit failed #8409

Closed
3 tasks done
bxfjb opened this issue Jul 19, 2024 · 1 comment · Fixed by #8410
Closed
3 tasks done

[Bug] Message at the end of a file may never be uploaded if last commit failed #8409

bxfjb opened this issue Jul 19, 2024 · 1 comment · Fixed by #8410

Comments

@bxfjb
Copy link
Contributor

bxfjb commented Jul 19, 2024

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Any

RocketMQ version

develop

JDK Version

1.8

Describe the Bug

Current tiered storage will call FileSegment#commitAsync actively if the appended file is full, but ignoring the commit result, which may cause the last part of messages will never be uploaded.
2024-07-19 17-14-12屏幕截图

Steps to Reproduce

Running broker and enable tiered storage, waiting until the last part of a commit log file is commit and failed.

What Did You Expect to See?

Messages that failed to be committed should be committed again.

What Did You See Instead?

The messages will not be commit ever.

Additional Context

No response

@lizhimins
Copy link
Member

Good catch

lizhimins pushed a commit that referenced this issue Jul 23, 2024
…st part of a file failed (#8410)

Co-authored-by: zhaoyuhan <zhaoyuhan@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants