Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8409] Fix tiered storage roll file logic if committing the last part of a file failed #8410

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

bxfjb
Copy link
Contributor

@bxfjb bxfjb commented Jul 19, 2024

Which Issue(s) This PR Fixes

Fixes #8409

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.06%. Comparing base (d9d53d5) to head (2331d56).

Files Patch % Lines
...ache/rocketmq/tieredstore/file/FlatAppendFile.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8410      +/-   ##
=============================================
- Coverage      45.12%   45.06%   -0.06%     
+ Complexity     10931    10925       -6     
=============================================
  Files           1274     1274              
  Lines          88970    88974       +4     
  Branches       11434    11435       +1     
=============================================
- Hits           40144    40100      -44     
- Misses         43826    43865      +39     
- Partials        5000     5009       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins changed the title [ISSUE #8409] Tiered storage shouldn't roll new file if committing the last part of a file failed [ISSUE #8409] Fix tiered storage roll file logic if committing the last part of a file failed Jul 23, 2024
@lizhimins lizhimins merged commit 6fb455a into apache:develop Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Message at the end of a file may never be uploaded if last commit failed
3 participants