Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jetcd and grpc dependency #28780

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Improve jetcd and grpc dependency #28780

merged 1 commit into from
Oct 17, 2023

Conversation

sandynz
Copy link
Contributor

@sandynz sandynz commented Oct 17, 2023

Changes proposed in this pull request:

  • Upgrade jetcd dependency version from 0.7.5 to 0.7.6. But it still reference old version of grpc-protobuf (which will be upgraded to 1.58.0 without vulnerabilities)
  • Replace grpc-all dependency to separated ones to reduce unnecessary dependencies

grpc-all includes too much dependencies with compile scope, e.g. grpc-testing which depends on junit on compile scope, and it'll be removed from dependencies.

<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-testing</artifactId>
<version>1.58.0</version>
<scope>compile</scope>

Simplified dependency chain: grpc-xxx <- jetcd-grpc <- jetcd-core.


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

Replace grpc-all dependency to separated ones
@sandynz sandynz added type: refactor type: dependencies Pull requests that update a dependency file labels Oct 17, 2023
@sandynz sandynz added this to the 5.4.1 milestone Oct 17, 2023
@azexcy azexcy merged commit 5c6a968 into apache:master Oct 17, 2023
133 checks passed
@sandynz sandynz deleted the dev-1 branch October 17, 2023 02:46
sandynz added a commit that referenced this pull request Oct 17, 2023
Replace grpc-all dependency to separated ones

(cherry picked from commit 5c6a968)
terrymanu added a commit that referenced this pull request Oct 21, 2023
* Update h2 version (#28736)

* Update h2 license (#28739)

* Upgrade dependencies versions (#28740)

* Upgrade guava version

* Upgrade grpc version

* Upgrade netty version

* Upgrade postgresql version

* Upgrade json-path version

* Resolve dependency conflict

* Resolve dependency conflict for json-path

* Resolve dependency conflict for json-path

* Upgrade dependencies version (#28763)

* Upgrade zookeeper version

* Upgrade zookeeper version

* Upgrade zookeeper version

* Upgrade logback version

* Upgrade logback version

* Upgrade logback version

* Upgrade junit version

* Upgrade junit version

* Resolve dependencies conflict for guava (#28743)

* Upgrade guava version

* Upgrade grpc version

* Upgrade netty version

* Upgrade postgresql version

* Upgrade json-path version

* Resolve dependency conflict

* Resolve dependency conflict for json-path

* Resolve dependency conflict for json-path

* Resolve dependency conflict for checker-qual

* Resolve dependency conflict for checker-qual

* Resolve dependency conflict for error_prone_annotations

* Upgrade jetcd dependency version to 0.7.6; (#28780)

Replace grpc-all dependency to separated ones

(cherry picked from commit 5c6a968)

* Improve PostgreSQL TestDecodingPlugin encoding (#28781)

* Improve SimpleMemoryPipelineChannelTest

* Use UTF-8 for PostgreSQL TestDecodingPlugin

(cherry picked from commit d1f4df8)

* Fix : fix nightly ci (#28782)

* Fix : fix nightly ci

* Revert : revert the fix

* Add : add denpendencies in LICENSE file (#28783)

* Refactor : refactor the example version to 5.4.1 (#28784)

* update release note for 5.4.1 (#28785)

* Document : update release note

* Document : update release note

* Document : update README and downloads link for release (#28786)

* Fix : update the scm to 5.4.1

* Document : format the release note

* Document : format the release note

* [maven-release-plugin] prepare release 5.4.1

* [maven-release-plugin] prepare for next development iteration

* Merge 5.4.1-relase to master

* Merge 5.4.1-relase to master

* Merge 5.4.1-relase to master

---------

Co-authored-by: Liang Zhang <zhangliang@apache.org>
Co-authored-by: Hongsheng Zhong <zhonghongsheng@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Pull requests that update a dependency file type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants