-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-40613][BUILD] Upgrade sbt-protoc to 1.0.6 #38049
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Sep 29, 2022
dongjoon-hyun
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Merged to master |
cc @HyukjinKwon for who has looked on the SBT issue for spark connect. |
HyukjinKwon
reviewed
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
late LGTM |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 26, 2024
…c` to `1.0.7` ### What changes were proposed in this pull request? The pr aims to upgrade: - `sbt-assembly` from `2.1.5` to `2.2.0` - `sbt-protoc` from `1.0.6` to `1.0.7` ### Why are the changes needed? - `sbt-assembly`, the full release notes: v2.20: https://github.com/sbt/sbt-assembly/releases/tag/v2.2.0 Reduce memory usage by avoiding to buffer entry contents during MergeStrategy.deduplicate in sbt/sbt-assembly#520 - `sbt-protoc` thesamet/sbt-protoc@v1.0.6...v1.0.7 The last upgrade happened one and a half years ago #38049 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45696 from panbingkun/sbt-assembly_sbt-protoc. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…c` to `1.0.7` ### What changes were proposed in this pull request? The pr aims to upgrade: - `sbt-assembly` from `2.1.5` to `2.2.0` - `sbt-protoc` from `1.0.6` to `1.0.7` ### Why are the changes needed? - `sbt-assembly`, the full release notes: v2.20: https://github.com/sbt/sbt-assembly/releases/tag/v2.2.0 Reduce memory usage by avoiding to buffer entry contents during MergeStrategy.deduplicate in sbt/sbt-assembly#520 - `sbt-protoc` thesamet/sbt-protoc@v1.0.6...v1.0.7 The last upgrade happened one and a half years ago apache#38049 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45696 from panbingkun/sbt-assembly_sbt-protoc. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR upgrade sbt-protoc to 1.0.6.
Why are the changes needed?
sbt-protoc 1.0.1 dose not exist.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.