Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47554][BUILD] Upgrade sbt-assembly to 2.2.0 and sbt-protoc to 1.0.7 #45696

Closed
wants to merge 2 commits into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Mar 25, 2024

What changes were proposed in this pull request?

The pr aims to upgrade:

  • sbt-assembly from 2.1.5 to 2.2.0
  • sbt-protoc from 1.0.6 to 1.0.7

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Mar 25, 2024
@panbingkun panbingkun changed the title [WIP] test sbt-assembly and sbt-protoc [SPARK-47554][BUILD] Upgrade sbt-assembly to 2.2.0 and sbt-protoc to 1.0.7 Mar 26, 2024
@panbingkun panbingkun marked this pull request as ready for review March 26, 2024 01:20
@HyukjinKwon
Copy link
Member

Merged to master.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

sweisdb pushed a commit to sweisdb/spark that referenced this pull request Apr 1, 2024
…c` to `1.0.7`

### What changes were proposed in this pull request?
The pr aims to upgrade:
- `sbt-assembly` from `2.1.5` to `2.2.0`
- `sbt-protoc` from `1.0.6` to `1.0.7`

### Why are the changes needed?
- `sbt-assembly`, the full release notes:
v2.20: https://github.com/sbt/sbt-assembly/releases/tag/v2.2.0
Reduce memory usage by avoiding to buffer entry contents during MergeStrategy.deduplicate in sbt/sbt-assembly#520

- `sbt-protoc`
thesamet/sbt-protoc@v1.0.6...v1.0.7
The last upgrade happened one and a half years ago
apache#38049

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#45696 from panbingkun/sbt-assembly_sbt-protoc.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants